Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove easter egg mentioning competitor #2250

Merged
merged 1 commit into from Jun 10, 2022
Merged

fix: Remove easter egg mentioning competitor #2250

merged 1 commit into from Jun 10, 2022

Conversation

kylecarbs
Copy link
Contributor

@kylecarbs kylecarbs commented Jun 10, 2022

This is more confusing than helpful!

This is more confusing than helpful!
@kylecarbs kylecarbs requested a review from misskniss Jun 10, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) Jun 10, 2022
@misskniss
Copy link
Member

@misskniss misskniss commented Jun 10, 2022

We know this was simply friendly ribbing of a capable competitor. In the spirit of mutual respect and making sure there is not any miscommunication of the intent among our community, let's pull this out.

@kylecarbs kylecarbs self-assigned this Jun 10, 2022
bpmct
bpmct approved these changes Jun 10, 2022
Copy link
Member

@misskniss misskniss left a comment

I will say that I am not opposed to a good friendly ribbing in general as it can be a validating expression. In this case, I would prefer to pull this out as we are getting closer and closer to a 'first release' in this milestone.

@kylecarbs kylecarbs closed this Jun 10, 2022
auto-merge was automatically disabled Jun 10, 2022

Pull request was closed

@kylecarbs kylecarbs deleted the removeegg branch Jun 10, 2022
@kylecarbs kylecarbs restored the removeegg branch Jun 10, 2022
@kylecarbs kylecarbs reopened this Jun 10, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) Jun 10, 2022
Copy link
Member

@johnstcn johnstcn left a comment

😢

@kylecarbs kylecarbs merged commit f79ab7f into main Jun 10, 2022
25 of 26 checks passed
@kylecarbs kylecarbs deleted the removeegg branch Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants