fix: Show correct 'no results' message on workspace filters#2103
Conversation
| </TableCell> | ||
| </TableRow> | ||
| <> | ||
| {query === "owner:me" || query === "" ? ( |
There was a problem hiding this comment.
Suggestion: I'd make these constants and re-use those constants here and in the form menu. Maybe in utils/workspaces.ts
|
Suggestion: Can we adjust the storybook so that there's a case for each the paths? See what I mean here: https://www.chromatic.com/test?appId=624de63c6aacee003aa84340&id=629e690bcbc710004ad776c9 |
|
Will need some guidance on the story stuff, I'm looking at https://github.com/coder/coder/blob/main/site/src/pages/WorkspacesPage/WorkspacesPageView.stories.tsx and I'm pretty lost on how to add my query stuff. |
|
@f0ssel happy to get on discord sometime today and figure out the storybook stuff |
|
Probably some of these conflicts are related to this PR #2097 basically what I made to cause this was to move all the logic from WorkspacePage to the WorkspacePageView so we could easily test that using Storybook. Please, let me know if you need help to solve the conflict. |
f0ssel
force-pushed
the
f0ssel/fix-no-results
branch
from
2b69691 to
b0d1bb0
Compare
4 participants
Fixes #2042.
Open to suggestions on what to display here, right now there's currently no description text.