Skip to content

Update fork button image#18385

Merged
mchammer01 merged 3 commits intogithub:mainfrom
aisgbnok:update-fork-image
Jun 6, 2022
Merged

Update fork button image#18385
mchammer01 merged 3 commits intogithub:mainfrom
aisgbnok:update-fork-image

Conversation

@aisgbnok
Copy link
Copy Markdown
Contributor

@aisgbnok aisgbnok commented Jun 1, 2022 •
edited
Loading

Why:

Closes #18384

What's being changed:

The fork_button.jpg image is being replaced with an updated fork_button.png.

Concerns

I do have a concern. I checked to see where the fork_button.jpg was being used and it was used in some of the translated content. I understand that public contributors are unable to change translated content. So I did not modify the pages. However, removing the fork_button.jpg may cause issues if the translated pages use that image. (It was deleted and replaced with .png).

I separated the removal so that a8f9072 can be reverted if this is an issue.

Here is a screenshot of all the locations fork_button.jpg may need to be changed to fork_button.png.
Fork Button Changes

Check off the following:

  • I have reviewed my changes in staging (look for "Automatically generated comment" and click Modified to view your latest changes).
  • For content changes, I have completed the self-review checklist.

Writer impact (This section is for GitHub staff members only):

  • This pull request impacts the contribution experience
    • I have added the 'writer impact' label
    • I have added a description and/or a video demo of the changes below (e.g. a "before and after video")

@github-actions github-actions Bot added the triage Do not begin working on this issue until triaged by the team label Jun 1, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 1, 2022 •
edited
Loading

Automatically generated comment ℹ️

This comment is automatically generated and will be overwritten every time changes are committed to this branch.

The table contains an overview of files in the content directory that have been changed in this pull request. It's provided to make it easy to review your changes on the staging site. Please note that changes to the data directory will not show up in this table.

Content directory changes

You may find it useful to copy this table into the pull request summary. There you can edit it to share links to important articles or changes and to give a high-level overview of how the changes in your pull request support the overall goals of the pull request.

Source Preview Production What Changed
get-started/quickstart/contributing-to-projects.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
get-started/quickstart/fork-a-repo.md fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae
 fpt
ghec
ghes@ 3.5 3.4 3.3 3.2 3.1
ghae

@cmwilson21 cmwilson21 added content This issue or pull request belongs to the Docs Content team waiting for review Issue/PR is waiting for a writer's review get started Content related to "Getting Started" doc set and removed triage Do not begin working on this issue until triaged by the team labels Jun 2, 2022
@cmwilson21
Copy link
Copy Markdown
Contributor

cmwilson21 commented Jun 2, 2022

@aisgbnok Thanks so much for opening a PR! I'll get this triaged for review ⚡

mchammer01
mchammer01 approved these changes Jun 6, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@mchammer01 mchammer01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aisgbnok 👋🏻 - thanks for updating this screenshot ✨
LGTM :shipit:

@mchammer01 mchammer01 enabled auto-merge June 6, 2022 10:45
@mchammer01 mchammer01 merged commit 1ae7ef1 into github:main Jun 6, 2022
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 6, 2022

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡

@aisgbnok aisgbnok deleted the update-fork-image branch June 6, 2022 16:16
@aisgbnok aisgbnok restored the update-fork-image branch June 16, 2022 03:59
@aisgbnok aisgbnok deleted the update-fork-image branch June 16, 2022 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mchammer01 mchammer01 mchammer01 approved these changes

Assignees

No one assigned

Labels

content This issue or pull request belongs to the Docs Content team get started Content related to "Getting Started" doc set waiting for review Issue/PR is waiting for a writer's review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fork Button Image is outdated

3 participants

@aisgbnok @cmwilson21 @mchammer01