Skip to content

Update workspace-config.md #46154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update workspace-config.md #46154

wants to merge 1 commit into from

Conversation

kentytik
Copy link

@kentytik kentytik commented May 26, 2022

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@pullapprove pullapprove bot requested a review from dgp1130 May 26, 2022 15:23
Copy link
Contributor

@dgp1130 dgp1130 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this update. I think you need to change the commit message to align with our required formatting. A little more specific message would be useful too. Maybe:

docs: correct workspace `assets` type

@ngbot ngbot bot modified the milestone: Backlog Jun 8, 2022
@dylhunn
Copy link
Contributor

dylhunn commented Jun 24, 2022

@kentytik Would you still like to merge this PR? If so, can you rebase it and amend the message to read:

docs: correct workspace `assets` type

@dylhunn
Copy link
Contributor

dylhunn commented Jun 24, 2022

Nevermind -- this looks to be already fixed at head.

@dylhunn dylhunn closed this Jun 24, 2022
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants