Add Node v18 to CI #48824
Merged
Add Node v18 to CI #48824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
the
For Uncommitted Bug
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
|
|
|
IIRC we may have agreed that we want to test latest plus the last two LTS releases before that, so we would be replacing 17 here, not adding to it. |
|
Yep 18 should just replace 17 as current active development version. |
|
PR has been updated. The Azure pipeline needs to be updated -- it appears that this lives in a different repo? |
andrewbranch
approved these changes
Apr 26, 2022
|
I’ve updated the Azure Pipeline. Thanks @ddzz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This PR adds Node v18 to the CI configuration and removes Node v17.
actions/setup-nodehas also been updated to the latest version.Fixes #48825