Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need both labels "cla-signed" and "cla-not-signed"? #453

Open
iritkatriel opened this issue May 21, 2022 · 2 comments
Open

Do we need both labels "cla-signed" and "cla-not-signed"? #453

iritkatriel opened this issue May 21, 2022 · 2 comments
Labels
labels

Comments

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented May 21, 2022

No description provided.

@ezio-melotti
Copy link
Member

@ezio-melotti ezio-melotti commented May 21, 2022

I think CLA not signed can go, since there are no open PRs that use it.

However there are still 1.2k+ open PRs with the CLA signed label so the label is probably needed unless there is a way to reevaluate all those open PRs with the new CLA bot (@ambv?).

If someone needs to prove that the author of a merged PR had signed the CLA, it should be possible to do it even after the labels are removed (the label addition is still in the issue logs, and the signing date can still be compared with the merging date).

@JelleZijlstra
Copy link
Member

@JelleZijlstra JelleZijlstra commented May 21, 2022

All of these PRs also have the new required "CLA signed" GH Actions check, so I don't think there's much value in keeping it around.

@ezio-melotti ezio-melotti added the labels label May 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels
Projects
Status: In Progress
Development

No branches or pull requests

3 participants