Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-89369: fix test_contextlib_async to finalize event loop after each test #93074

Merged
merged 3 commits into from May 24, 2022
Merged

GH-89369: fix test_contextlib_async to finalize event loop after each test #93074

merged 3 commits into from May 24, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented May 22, 2022 •
edited

Closes #89369

@kumaraditya303 kumaraditya303 requested a review from 1st1 as a code owner May 22, 2022
@bedevere-bot bedevere-bot added tests awaiting review labels May 22, 2022
@kumaraditya303 kumaraditya303 changed the title fix test_contextlib_async to finalize event loop after each test GH-89369: fix test_contextlib_async to finalize event loop after each test May 22, 2022
@kumaraditya303 kumaraditya303 self-assigned this May 22, 2022
@kumaraditya303 kumaraditya303 requested a review from vstinner May 22, 2022
vstinner
vstinner reviewed May 23, 2022
View changes
Lib/test/test_contextlib_async.py Outdated Show resolved Hide resolved
@kumaraditya303 kumaraditya303 requested a review from vstinner May 24, 2022
@vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2022

I confirm that this PR fix #89369 for me.

@vstinner vstinner merged commit d2ef66a into python:main May 24, 2022
12 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 24, 2022

Thanks @kumaraditya303 for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 24, 2022

GH-93170 is a backport of this pull request to the 3.11 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented May 24, 2022

GH-93171 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 24, 2022
@kumaraditya303 @miss-islington
pythonGH-89369: test_contextlib_async finalizes event loop after each…
3746bb5 
… test (pythonGH-93074)

Use asyncio.run().
(cherry picked from commit d2ef66a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this issue May 24, 2022
@kumaraditya303 @miss-islington
pythonGH-89369: test_contextlib_async finalizes event loop after each…
d853b81 
… test (pythonGH-93074)

Use asyncio.run().
(cherry picked from commit d2ef66a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@vstinner
Copy link
Member

@vstinner vstinner commented May 24, 2022

Thanks for the fix! Merged.

miss-islington added a commit that referenced this issue May 24, 2022
@miss-islington @kumaraditya303
GH-89369: test_contextlib_async finalizes event loop after each test (G…
a6ee7f9 
…H-93074)

Use asyncio.run().
(cherry picked from commit d2ef66a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this issue May 24, 2022
@miss-islington @kumaraditya303
GH-89369: test_contextlib_async finalizes event loop after each test (G…
502dba0 
…H-93074)

Use asyncio.run().
(cherry picked from commit d2ef66a)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1st1 1st1

@vstinner vstinner

Assignees

@kumaraditya303 kumaraditya303

Labels
skip news tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test_contextlib_async logs "Task was destroyed but it is pending" messages
4 participants
@kumaraditya303 @vstinner @miss-islington @bedevere-bot