Ruby: flow through getters/setters#9287
Merged
Merged
Conversation
aibaars
force-pushed
the
instance-variable-flow-2
branch
from
4418c8d to
05d8452
Compare
hvitved
requested changes
May 24, 2022
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM. Let's see what DCA says.
aibaars
force-pushed
the
instance-variable-flow-2
branch
from
05d8452 to
a6508e7
Compare
aibaars
force-pushed
the
instance-variable-flow-2
branch
from
c1e5464 to
033df76
Compare
hvitved
approved these changes
May 25, 2022
Contributor
hvitved
left a comment
hvitved
left a comment
There was a problem hiding this comment.
LGTM. Let's wait for DCA before merging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for data flow through getter/setter methods. It assumes that setter methods like
field=write to an instance variable named@field. This is to handle cases where the body of the setter method is not visible to the analysis. While this is an approximation, I'd expect very few cases of false flow. If my assumption turns out to be wrong we should make the analysis more precise.