DanielRosenwasser
Follow
DanielRosenwasser
Follow
Pinned
721 contributions in the last year
Contribution activity
May 2022
Created 18 commits in 3 repositories
Created a pull request in microsoft/TypeScript that received 3 comments
Temporarily revert unconstrained type parameter strictness in TS 4.7
This PR reverts #48366.
We've seen that the change to disallow a generic T to be assignable to {} are particularly disruptive to existing codebases…
+6
−808
•
3
comments
Opened 3 other pull requests in 1 repository
microsoft/TypeScript
3
merged
Reviewed 25 pull requests in 1 repository
microsoft/TypeScript
25 pull requests
- Fix uncalled function check usage detection for && expressions
- Fix path completions for typesVersions
- Avoid binding readonly properties as special properties on a function symbol
- No errors on apparent type of bigint or symbol, even for recent targets
-
Optimize the transformed output of
JSXSpreadAttributes containing anObjectLiteralExpression - fix(48556) / confused comment in test
- In typeof x === object, type parameters extending unknown narrow like unknown itself
- fix(49058): Language service crashes for static member in class with unresolved base members
- fix(47821): Assertion failure on "convert to default export" in module augmentation
- Fixed an issue with quickInfo crashing on a function property returned from generic function
- Allow referencing type-only exports as namespace members in ImportTypes and TypeQueries
- Add JSDoc's @inheritDoc Support for Static Class Members for TypeScript
- fix(48948): constructor can't be the name of class accessors and generators
- fix(44466): Fixes parsing contextual keyword casts as arrow functions
- Fix module specifier generation crash from typesVersions
- Flag resolution mode assertions in non-nightly builds
- Respect importModuleSpecifierEnding inside node_modules packages
- Allow export map entries to remap back to input files for a program
- Harden combineProjectOutputForReferences against empty results
- Fix node16 tests for module resolution
- Revert "feat(47595): allow using private fields in type queries"
- When source file is redirected, set the prototype correctly in node factory
- No error on toplevel return in JS
- Don’t let other completions shadow type keywords in type locations
- Revert "Don't treat a colon in a conditional expression branch as part of an arrow function"
Created an issue in microsoft/vscode that received 7 comments
Refactors returning edits on anonymous buffers create new anonymous buffers, confuses TSServer
const _unused = { method() { [|this.doThing();|] } } Request refactorings, and extract to a function at the top-level. Expected: no crash Actual: I…
7
comments
Opened 14 other issues in 2 repositories
microsoft/TypeScript
11
open
2
closed
- Design Meeting Notes, 5/13/2022
- TypeScript 4.8 Iteration Plan
- Language service crashes for static member in class with unresolved base members
-
resolution-modeFeedback - Experiment with a flattened the control flow graph representation
- Enrich TS Server Tracepoints
- Determining Module Migration and Shipping Strategy
- Refactoring assertion failure with invalid object type syntax
- TS Server Performance Analysis Tooling
- Investigate (possibly contextual) truthiness narrowing of type parameters
- Find all references crash on literal with base constraint contextual type
- Design Meeting Notes, 5/4/2022
- Design Meeting Notes, 4/27/2022