Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.11] gh-92675: venv: Fix ensure_directories() to again accept a Path for env_dir (GH-92676) #92961

Open
wants to merge 1 commit into
base: 3.11
Choose a base branch
from

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented May 19, 2022

Co-authored-by: Jelle Zijlstra jelle.zijlstra@gmail.com
Co-authored-by: Alex Waygood Alex.Waygood@Gmail.com
(cherry picked from commit 30deeac)

Co-authored-by: David Foster david@dafoster.net

… for env_dir (pythonGH-92676)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 30deeac64925effe46cb5f1cd091ccb4c850ce83)

Co-authored-by: David Foster <david@dafoster.net>
@miss-islington miss-islington requested a review from vsajip as a code owner May 19, 2022
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 19, 2022

Status check is done, and it's a success .

2 similar comments
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 19, 2022

Status check is done, and it's a success .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 19, 2022

Status check is done, and it's a success .

@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 19, 2022

Status check is done, and it's a success .

@JelleZijlstra JelleZijlstra self-assigned this May 19, 2022
@miss-islington
Copy link
Contributor Author

@miss-islington miss-islington commented May 19, 2022

Sorry, I can't merge this PR. Reason: 3 of 6 required status checks are expected..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting merge type-bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants