Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept any layer as a target for vd.effect.Base #68

Open
clabe45 opened this issue May 16, 2021 · 0 comments
Open

Accept any layer as a target for vd.effect.Base #68

clabe45 opened this issue May 16, 2021 · 0 comments
Labels
good first issue help wanted priority:high
Projects
Audio System

Comments

@clabe45
Copy link
Collaborator

@clabe45 clabe45 commented May 16, 2021

Currently, the only layers vd.effect.Base accepts as targets are visual layers. Change its methods' argument types to accept the Base layer instead of just Visual ones.

For some reason, apply takes the target as an argument, even though it caches it when attached. We can take care of that later.
@clabe45 clabe45 added this to To do in Audio System via automation May 16, 2021
@clabe45 clabe45 moved this from To do to In progress in Audio System May 23, 2021
clabe45 added a commit that referenced this issue Jul 16, 2021
@clabe45
♻️ Split Base effect into Base and Visual
fca29fa 
So we can add audio effects

Resolves #69 and #68
clabe45 added a commit that referenced this issue Sep 8, 2021
@clabe45
♻️ Split Base effect into Base and Visual
2fcacc6 
So we can add audio effects

Resolves #69 and #68
@clabe45 clabe45 added the help wanted label Feb 20, 2022
clabe45 added a commit that referenced this issue Feb 24, 2022
@clabe45
♻️ Split Base effect into Base and Visual
f281761 
So we can add audio effects

Resolves #69 and #68
clabe45 added a commit that referenced this issue Mar 6, 2022
@clabe45
♻️ Split Base effect into Base and Visual
b8df3c6 
So we can add audio effects

Resolves #69 and #68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted priority:high
Projects
Audio System
In progress
Milestone
No milestone
Development

No branches or pull requests
1 participant
@clabe45