Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Edge Function Guide shows different deploy method than Dashboard #6230

Open
GaryAustin1 opened this issue Mar 31, 2022 · 5 comments
Open

Edge Function Guide shows different deploy method than Dashboard #6230

GaryAustin1 opened this issue Mar 31, 2022 · 5 comments
Labels
documentation functions good first issue

Comments

@GaryAustin1
Copy link
Contributor

@GaryAustin1 GaryAustin1 commented Mar 31, 2022

Improve documentation

Link

Edge Deploy Guide

Describe the problem

Guide says:
supabase functions deploy hello-world

Dashboard Function page says:
supabase functions deploy hello --project-ref ugccqefilvseqbseypbq

Describe the improvement

They should be the same and which ever method is correct. ( I can't tell which is correct because of a CLI windows bug at the moment)

Additional context

Add any other context or screenshots that help clarify your question.
@GaryAustin1 GaryAustin1 added the documentation label Mar 31, 2022
@GaryAustin1
Copy link
Contributor Author

@GaryAustin1 GaryAustin1 commented Mar 31, 2022

Now that I can test it... It looks like either works... If not there the CLI seems to still use default settings to upload with the project reference.

@Isaiah-Hamilton Isaiah-Hamilton added the good first issue label Apr 1, 2022
@kiwicopple
Copy link
Member

@kiwicopple kiwicopple commented Apr 5, 2022

we should update the Dashboard Function page to be hello-world - this helps devs to understand that it's good practice to use hyphens

@Hallidayo
Copy link
Contributor

@Hallidayo Hallidayo commented Apr 6, 2022 •
edited

@kiwicopple - Can I be assigned to this one please? Also is the correct page

@Isaiah-Hamilton
Copy link
Collaborator

@Isaiah-Hamilton Isaiah-Hamilton commented Apr 9, 2022

All yours @Hallidayo, and yes that's the correct page.

@Hallidayo
Copy link
Contributor

@Hallidayo Hallidayo commented Apr 9, 2022

I've created a pr for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation functions good first issue
Projects
Team: Dashboard
Status: No status
Milestone
No milestone
Development

No branches or pull requests
4 participants
@kiwicopple @Hallidayo @GaryAustin1 @Isaiah-Hamilton