Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find max recursion #1010

Merged
merged 9 commits into from May 9, 2022
Merged

Find max recursion #1010

merged 9 commits into from May 9, 2022

Conversation

Exortions
Copy link
Contributor

@Exortions Exortions commented May 8, 2022 •
edited by appgurueu

Open in Gitpod know more

Describe your change:

  • Add an algorithm

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in its comments that points to Wikipedia or other similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

appgurueu
appgurueu previously approved these changes May 8, 2022
View changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

You seem to have kinda duplicated my explanatory comments regarding the left shift. Also note that you don't have to open a new PR each time. Nevertheless, this is mergeable.

@Exortions
Copy link
Contributor Author

@Exortions Exortions commented May 8, 2022 •
edited

You seem to have kinda duplicated my explanatory comments regarding the left shift. Also note that you don't have to open a new PR each time. Nevertheless, this is mergeable.

Yeah, I don't know how to add commits to a PR, and I used your explanatory comments as they explained it very nicely.

appgurueu
appgurueu previously approved these changes May 8, 2022
View changes
Copy link
Collaborator

@appgurueu appgurueu left a comment

Fixed.

@Exortions
Copy link
Contributor Author

@Exortions Exortions commented May 8, 2022

Thanks for the changes, I know now how to add commits to a PR :)

@raklaptudirm raklaptudirm added algorithm code quality labels May 9, 2022
@raklaptudirm raklaptudirm merged commit 21a8511 into TheAlgorithms:master May 9, 2022
3 checks passed
@appgurueu appgurueu added feature and removed code quality labels May 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appgurueu appgurueu

@raklaptudirm raklaptudirm

Assignees
No one assigned
Labels
algorithm feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Exortions @appgurueu @raklaptudirm