add render_preview test helper
#1347
Conversation
| @@ -41,14 +41,49 @@ def refute_component_rendered | |||
| # @param component [ViewComponent::Base, ViewComponent::Collection] The instance of the component to be rendered. | |||
| # @return [Nokogiri::HTML] | |||
| def render_inline(component, **args, &block) | |||
| @rendered_component = | |||
| @rendered_content = | |||
There was a problem hiding this comment.
Super minor, but I wonder if this is being used directly by any libraries/apps and if renaming it would break anything.
There was a problem hiding this comment.
I do wonder that too. I'll add a note to the changelog.
There was a problem hiding this comment.
This indeed is used by lots of people! #1372 and #1373 offer two fixes.
I wonder if we should update the documentation to more explicitly direct people towards writing expectations that use page if they are using RSpec and Capybara?
expect(page).to have_link("Home page", href: root_path)
| @@ -23,6 +23,8 @@ def index | |||
| end | |||
|
|
|||
| def previews | |||
| find_preview | |||
There was a problem hiding this comment.
Just curious, why was this change necessary?
There was a problem hiding this comment.
Good question. Since we're calling previews directly from render_preview, before_action isn't called. In fact, I think we could inline find_preview here!
I like this a lot!
Similar to how we adopted i18n, slots v2 , and other features, what are your thoughts on extracting the test functionality into it's own namespace and not include it by default? That way we can make breaking changes as/if needed without needing a major release.
Co-authored-by: Blake Williams <blakewilliams@github.com>
Co-authored-by: Blake Williams <blakewilliams@github.com>
In working on #1347, @camertron and I realized that it's a little strange to have our test suite in two places. In the interest of having our suite serve as an example for consumers of the framework, we decided to move everything into the sandbox application.
* Move tests into sandbox directory In working on #1347, @camertron and I realized that it's a little strange to have our test suite in two places. In the interest of having our suite serve as an example for consumers of the framework, we decided to move everything into the sandbox application. * use more specific name for test
In github#1347, rendered component has been renamed to rendered content. But its method name seems to be the same as before.
In github#1347, rendered component has been renamed to rendered content. But its method name seems to be the same as before.
…1372) * Rename accessor method name: rendered_component => rendered_content In #1347, rendered component has been renamed to rendered content. But its method name seems to be the same as before. * s/rendered_component/rendered_content/ in guide * Update docs/CHANGELOG.md * Update docs/CHANGELOG.md * Update docs/CHANGELOG.md Co-authored-by: Joel Hawksley <joelhawksley@github.com>
Summary
I've documented this change thoroughly, see the diff❤️