Changed pyclass name of PyArray and PyArrayIter #3612#3685
Merged
youknowone merged 6 commits intoMay 4, 2022
Conversation
youknowone
reviewed
May 3, 2022
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
Could you please add a related test to extra_tests/snippets/stdlib_array.py to ensure this behavior is now same for CPython and RustPython?
|
|
||
| #[pyattr] | ||
| #[pyclass(name = "array")] | ||
| #[pyclass(name = "array.array")] |
Member
There was a problem hiding this comment.
we typically put only array here. the other array came from the module name.
Contributor
Author
There was a problem hiding this comment.
Understood! I fixed it and added tests.
Member
|
please check your git config user.email matches to your account. It is referring different account. |
youknowone
approved these changes
May 4, 2022
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
looks good, thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3612
The issue is
but it is "The name of array.array iterator has to be arrayiterator but array_iterator in RustPython", right?
and I also changed also PyArray's name,
because it looks different from CPython's.