Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetadataIndexStateService block log messages are confusing #85207

Open
DaveCTurner opened this issue Mar 22, 2022 · 2 comments · May be fixed by #85237
Open

MetadataIndexStateService block log messages are confusing #85207

DaveCTurner opened this issue Mar 22, 2022 · 2 comments · May be fixed by #85237
Labels
:Data Management/Indices APIs >enhancement good first issue Supportability Team:Data Management

Comments

@DaveCTurner
Copy link
Contributor

@DaveCTurner DaveCTurner commented Mar 22, 2022 •
edited

Tiny supportability nit: today we emit these log messages when adding a write block to an index:

[2022-03-22T19:43:26,897][INFO ][o.e.c.m.MetadataIndexStateService] [node_t1] adding block write to indices [[test-blocks/eLkrYpm_S3WNemfWpXrhPA]]
[2022-03-22T19:43:26,933][INFO ][o.e.c.m.MetadataIndexStateService] [node_t1] completed adding block write to indices [test-blocks]

This is kind of confusing, a block write sounds like we're writing a block of data. It's not clear that write is variable (we also say block read) or the name of a block setting. I think we should word this as adding [index.blocks.write] block to indices instead.
@DaveCTurner DaveCTurner added >enhancement :Data Management/Indices APIs Supportability labels Mar 22, 2022
@elasticmachine elasticmachine added the Team:Data Management label Mar 22, 2022
@elasticmachine
Copy link
Collaborator

@elasticmachine elasticmachine commented Mar 22, 2022

Pinging @elastic/es-data-management (Team:Data Management)

@dakrone dakrone added the good first issue label Mar 22, 2022
@mslowiak
Copy link

@mslowiak mslowiak commented Mar 22, 2022

Hi there!
@dakrone, can I pick this up?

@mslowiak mslowiak linked a pull request that will close this issue Mar 22, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Indices APIs >enhancement good first issue Supportability Team:Data Management
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Issue 85207: Adjust logging message for adding index block
4 participants
@dakrone @DaveCTurner @elasticmachine @mslowiak