Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix image options type #116

Open
clabe45 opened this issue Feb 20, 2022 · 1 comment
Open

Fix image options type #116

clabe45 opened this issue Feb 20, 2022 · 1 comment
Labels
good first issue help wanted priority:high

Comments

@clabe45
Copy link
Collaborator

@clabe45 clabe45 commented Feb 20, 2022

In line 4 of image.ts, the type ImageOptions is set to be the same as VisualOptions, when it really should be the same as VisualSourceOptions. VisualSourceOptions includes necessary fields for visual layers with an HTML element as its source. We just need to use this type instead of VisualOptions.
@clabe45 clabe45 added good first issue priority:high help wanted labels Feb 20, 2022
@eyuelberga
Copy link

@eyuelberga eyuelberga commented Feb 21, 2022

I would like to help out with this

@eyuelberga eyuelberga mentioned this issue Feb 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue help wanted priority:high
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@clabe45 @eyuelberga