JS: don't initialize sanitizer-guards in the standard library #8783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
the
Awaiting evaluation
erik-krogh
force-pushed
the
jsAbstractBi
branch
2 times, most recently
from
f6d816a
to
d54b223
Compare
erik-krogh
removed
the
Awaiting evaluation
erik-krogh
changed the title
ql/abstract-class-import
asgerf
reviewed
Apr 21, 2022
| * A sanitizer that blocks the `PrefixString` label when the start of the string is being tested as being of a particular prefix. | ||
| */ | ||
| abstract class PrefixStringSanitizer extends TaintTracking::SanitizerGuardNode, | ||
| TaintTracking::LabeledSanitizerGuardNode instanceof StringOps::StartsWith { |
There was a problem hiding this comment.
Is there a need to extend both SanitizerGuardNode and LabeledSanitizerGuardNode?
There was a problem hiding this comment.
Yep, the tests still pass.
javascript/ql/lib/semmle/javascript/security/dataflow/StoredXssCustomizations.qll
Outdated
Show resolved
Hide resolved
Co-authored-by: Asger F <asgerf@github.com>
Co-authored-by: Asger F <asgerf@github.com>
|
@henrymercer how do feel if we merge this PR? I would like to use the merge commit on |
asgerf
approved these changes
Apr 29, 2022
Sorry, I guess we were waiting for me to review again. Thanks for addressing my comments @erik-krogh, LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I did an experiment to revert the cached stages pattern.
That gave a whole bunch of QL-for-QL warnings from
ql/abstract-class-import.These warnings are caused by us having sanitizer-guards that were defined in
Xss.qll.I moved things around, including refactoring the old🙀 ).
Xss.qllwhere I moved things out intoQuery.qll/Customizations.qllfiles so they match the other queries.(Turns out the
js/html-constructed-from-inputquery relied on the previous behaviorThe change in results for ATM is caused by: 76bf8de
The results generally look better (the majority is removal of FPs).
This PR only affects the
XSSqueries, but the changed ATM results are forTaintedPath.So the results seem to be a bug caused by importing too many classes.
So I think we can conclude that this PR is a bug-fix for ATM.
The evaluation looks good.🚀
We gained one new result. Which is caused by some barrier-guards no longer falsely limiting the flow.
Also a slight performance improvement
I also made some small drive-by fixes of
ql/abstract-class-importto remove some benign results.