JS: track flow through string replace calls that just replace single chars for js/polynomial-redos #6736
+46
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erik-krogh
added
Awaiting evaluation
asgerf
approved these changes
May 4, 2022
Sorry for leaving this PR hanging so long. The evaluation is no longer available, but I trust it went fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
CVE-2021-3777: TP/TN
Evaluation looks OK.
One of the new results is from tracking through a path-separator-normalizer:
next = prev.replace(/\\/g, '/');.And the other is from escaping dots:
next = prev.replace(/\./g, `\\.`)So both TPs.