refactor(multiple): remove coercion members #24055
Merged
+469
−1,552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
coercion-members-again
branch
3 times, most recently
from
ef519a1
to
a5c2e4f
Compare
crisbeto
requested review from
andrewseguin,
devversion,
jelbourn,
mmalerba and
as
code owners
crisbeto
added
P2
* Replaces all usages of the `ngAcceptInputType` members with type declarations directly on the setters. * Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added.
devversion
approved these changes
Dec 6, 2021
crisbeto
added
the
merge ready
mmalerba
approved these changes
Dec 8, 2021
amysorto
pushed a commit
that referenced
this issue
Dec 14, 2021
* Replaces all usages of the `ngAcceptInputType` members with type declarations directly on the setters. * Replaces the lint rule that was checking that the correct coercion members were added with a rule that doesn't allow new coercion members to be added. (cherry picked from commit 24180d1)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
ngAcceptInputTypemembers with type declarations directly on the setters.