New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Community Event] Doc Tests Sprint #16292
Comments
|
@patrickvonplaten I would like to start with Maskformer for Tensorflow/Pytorch. Catch up with how the event goes. |
|
Awesome! Let me know if you have any questions :-) |
|
Hello! I'd like to take on Longformer for Tensorflow/Pytorch please. |
|
@patrickvonplaten I would like to start with T5 for pytorch and tensorflow |
|
Sounds great! |
|
LayoutLM is also taken as mentioned by a contributor on Discord! |
|
@patrickvonplaten I would take GPT and GPT-J (TensorFlow editions) if those are still available. I'm guessing GPT is GPT2? |
|
I will take Bert, Albert, and Bigbird for both Tensorflow/Pytorch |
|
I'll take Swin and ViT for Tensorflow |
|
I'd like DistilBERT for both TF and PT please |
@cakiki You can go for GPT2 (I updated the name in the test) |
|
Can I try GPT2 and GPTJ for Pytorch? if @ydshieh you are not doing so? |
|
I would like to try CLIP for Tensorflow and PyTorch. |
|
I'll take CANINE and TAPAS. |
|
@ydshieh Since the MobileBertForSequenceClassification is the copy of BertForSequenceClassification, so I think I will do check doc-test of MobileBert as well to overcome the error from |
|
I'll take FlauBERT and CamemBERT. |
|
@abdouaziz Awesome! Do you plan to work on both PyTorch and TensorFlow versions, or only one of them? |
|
I would like to work on LUKE model for both TF and PT |
|
@Tegzes you're lucky because there's no LUKE in TF ;) the list above actually just duplicates all models, but many models aren't available yet in TF. |
|
In this case, I will also take DeBERTa and DeBERTa-v2 for PyTorch |
|
I plan to work only with PyTorch |
True - sorry I've been lazy at creating this list! |
|
Happy to work on TrOCR (pytorch and TF) |
|
I take RoBERTa in PT and TF |
|
I would like to pick up XLM-RoBERTa in PT and TF. |
|
I can work on |
|
@ydshieh |
Hi, @hiromu166 Looks like we didn't upload a tokenizer for I will upload a tokenizer today! Thank you very much for pointing out this. |
|
I uploaded the tokenizer file spiece.model to hf-internal-testing/tiny-random-reformer. Let me know if you have any problem using it in the doctest |
|
@ydshieh |
|
@ydshieh quick question. @jessecambon and I are working on the DistilBert model but we're seeing many of the examples are actually drawn and built from the examples in |
|
Hi @bhadreshpsavani , Yes there is an issue regarding the target indices. Please follow this discussion #16523 (comment) I will discuss the team.
|
|
Hi, @jmwoloso & @jessecambon
In order to customize, you can use You can looks this change on Roberta as a reference. Let me know if you have any difficulty using this approach.
|
By the way, you don't have this issue for |
Hi @ydshieh, |
What I saw in So if you use the same checkpoint for PT/TF Electra, the PyTorch should have the same issue I think. Also, let's move this discussion to your PR. |
|
@ydshieh ok, thank you for the clarification. so is the goal then to move away from doc.py and have individual doc tests in the specific model architecture files? |
|
Hi, @jmwoloso not exactly. We still use The method |
|
ok, awesome. thanks @ydshieh! |
|
Hi, Is anyone working on BART TF version? If not I can try and contribute WRT that model. Thanks |
|
Not sure if someone is working on TF Bart. You can search the Pull request list. Otherwise, TF Wav2Vec2 should be a good one to try. Should be quite easy with the recent change in |
|
Since no one seems to have taken layoutlmv2 and the last activity on this thread was 25 days ago, I’m going to start working on layoutlmv2 :) Edit: The PR is ready for review now |
|
@patrickvonplaten I would like to start with |
|
@nandwalritik - that's great! Do you want to open a PR for this? |
|
Hi @patrickvonplaten , I am interested in working on data2VecText. Thanks! |
This issue is part of our Doc Test Sprint. If you're interested in helping out come join us on Discord and talk with other contributors!
Docstring examples are often the first point of contact when trying out a new library! So far we haven't done a very good job at ensuring that all docstring examples work correctly in🤗 Transformers - but we're now very dedicated to ensure that all documentation examples work correctly by testing each documentation example via Python's doctest (https://docs.python.org/3/library/doctest.html) on a daily basis.
In short we should do the following for all models for both PyTorch and Tensorflow:
Adding a documentation test for a model is a great way to better understand how the model works, a simple (possibly first) contribution to Transformers and most importantly a very important contribution to the Transformers community🔥
If you're interested in adding a documentation test, please read through the Guide to contributing below.
This issue is a call for contributors, to make sure docstring exmaples of existing model architectures work correctly. If you wish to contribute, reply in this thread which architectures you'd like to take :)
Guide to contributing:
Ensure you've read our contributing guidelines📜
Claim your architecture(s) in this thread (confirm no one is working on it)🎯
Implement the changes as in #15987 (see the diff on the model architectures for a few examples)💪
src/transformers/models/[model_name]/modeling_[model_name].py,src/transformers/models/[model_name]/modeling_tf_[model_name].pyorsrc/transformers/doc_utils.pyorsrc/transformes/file_utils.pyIn addition, there are a few things we can also improve, for example :
Open the PR and tag me @patrickvonplaten @ydshieh or @patil-suraj (don't forget to run🎊
make fixupbefore your final commit)# Copied from transformers.models.bert..., this means that the code is copied from that source, and our scripts will automatically keep that in sync. If you see that, you should not edit the copied method! Instead, edit the original method it's copied from, and run make fixup to synchronize that across all the copies. Be sure you installed the development dependencies withpip install -e ".[dev]", as described in the contributor guidelines above, to ensure that the code quality tools inmake fixupcan run.PyTorch Model Examples added to tests:
Tensorflow Model Examples added to tests:
The text was updated successfully, but these errors were encountered: