Skip to content

Update react/README.md#2451

Draft
rahulrk-dev wants to merge 4 commits intoairbnb:masterfrom
rahulrk-dev:DevTMK-patch-1
Draft

Update react/README.md#2451
rahulrk-dev wants to merge 4 commits intoairbnb:masterfrom
rahulrk-dev:DevTMK-patch-1

Conversation

@rahulrk-dev
Copy link
Copy Markdown

Fix jsx display issue in webpage
https://airbnb.io/javascript/react/#quotes

Fixes #2301

@Alejandrorn13

This comment has been minimized.

@ljharb
Copy link
Copy Markdown
Collaborator

ljharb commented Oct 15, 2021

I see the issue you’re referencing. Can you link to something that describes how this fixes it? This doesn’t fix it for all the other cases of self-closing elements in the page; is there a more holistic solution?

@rahulrk-dev
Copy link
Copy Markdown
Author

@ljharb Here's the output for the fix -
https://devtmk.github.io/javascript/react/#quotes

@ljharb
Copy link
Copy Markdown
Collaborator

ljharb commented Jan 2, 2022

@devtmk i'm confused; https://devtmk.github.io/javascript/react/#quotes has different JSX than https://airbnb.io/javascript/react/#quotes.

There's also highlighting issues here:

and probably a number of other places. It'd be great to figure out a way to fix them all at once, without requiring inline annotations.

@DetrojaRadhey
Copy link
Copy Markdown

@ljharb, I have used HTML character entities to display JSX code in a markdown format without being rendered as HTML.

Review this PR and let me know if any changes needed:
#3060

@ljharb ljharb marked this pull request as draft November 10, 2024 20:58
@ljharb
Copy link
Copy Markdown
Collaborator

ljharb commented Nov 10, 2024

@DetrojaRadhey i commented on the PR with how that doesn't fix it; but also, please don't post a duplicate PR. In the future, post a link to your changes and a maintainer can pull them in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JSX is not displayed correctly in webpage

4 participants