Feature: improve branch coverage by Dajamante · Pull Request #6036 · TheAlgorithms/Python

Dajamante · 2022-03-07T13:53:05Z

Describe your change:

closes #6020
Please see issue:

Fix a bug or typo in an existing algorithm?
Documentation change?

Checklist:

…pair()

… 100%

feat: issue #2 improves code coverage for insert_repair() from 88% to…

…en it shouldn't

Write 3 additional tests

feat: issue #4 reduces CCN of insert_repair() by 65%

feat: issue #8 adds coverage htmls to showcase improvement

fix: added docstring test for from_sequence

fix: removed code from main to doctest

fix: added unit tests for is_palindrome.py

…moved non-useful htmls)

Increase test coverage of data_structures/binary_tree/red_black_tree.py to 92%

Also wrap the function, so the function can be triggered by parameters instead of input().

Now, if using the command "coverage run -m closest_pair_of_points", we get coverage of 100%. Meanwhile, if using the command "coverage run -m pytest --doctest-modules closest_pair_of_points.py", we get coverage of 95%.

fix: issue #10 adjust documentation according to contribution guidelines

Adds the last (imo) reasonable test

poyea · 2022-03-17T03:06:30Z

        rotations necessary to maintain balance, and then returns the
        new root to this subtree (likely self).
        This is guaranteed to run in O(log(n)) time.
+


Suggested change

poyea · 2022-03-17T03:07:54Z

+
+
+    >>> epq2 = ElementPriorityQueue()
+    >>> q = [[epq2.enqueue(11)] for _ in range(101)]
+    Traceback (most recent call last):
+    ...
+    priority_queue_using_list.OverFlowError: Maximum queue size is 100


FAILED data_structures/queue/priority_queue_using_list.py::data_structures.queue.priority_queue_using_list.ElementPriorityQueue

poyea · 2022-03-17T03:08:20Z

+        >>> fpq = FixedPriorityQueue()
+        >>> fpq.enqueue(3, 10)
+        Traceback (most recent call last):
+        ...
+        ValueError: Valid priorities are 0, 1, and 2
+        >>> fpq = FixedPriorityQueue()
+        >>> q = [fpq.enqueue(0,5) for _ in range(101)]
+        Traceback (most recent call last):
+        ...
+        OverflowError: Maximum queue size is 100
+


FAILED data_structures/queue/priority_queue_using_list.py::data_structures.queue.priority_queue_using_list.FixedPriorityQueue

poyea · 2022-03-17T03:11:51Z

Please fix the build checks.

stale · 2022-04-16T04:02:37Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cclauss · 2022-04-16T06:40:28Z

+import re
 from random import random

+__all__ = ("re",)


Why do we need this??

cclauss · 2022-04-16T06:41:30Z

+        >>> hashTable._hash_function_2(1, 4) # next_prime_gt = 3, return 3 - (4 % 3) = 2
+        2
+        >>> hashTable = DoubleHash(5)
+        >>> hashTable._hash_function_2(3, 8) # next_prime(3) = 3, return 3 - (8 % 3) = 1
+        1


Suggested change

>>> hashTable._hash_function_2(1, 4) # next_prime_gt = 3, return 3 - (4 % 3) = 2

2

>>> hashTable = DoubleHash(5)

>>> hashTable._hash_function_2(3, 8) # next_prime(3) = 3, return 3 - (8 % 3) = 1

1

>>> hashTable._hash_function_2(1, 4) # next_prime_gt = 3, return 3 - (4 % 3) = 2

2

>>> hashTable = DoubleHash(5)

>>> hashTable._hash_function_2(3, 8) # next_prime(3) = 3, return 3 - (8 % 3) = 1

1

cclauss · 2022-04-16T06:43:02Z

All checks fail?

SnowdenSa · 2022-04-16T09:39:56Z

Nice work.

stale · 2022-06-13T04:58:35Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

poyea · 2022-06-13T05:06:18Z

Let's fix the tests? - this would be great to have

Dajamante · 2022-06-13T07:09:38Z

I agree! I will not have time unfortunately :(. But there are two tests that are failing according to the report.
================ 2 failed, 1117 passed, 108 warnings in 32.80s =================

poyea · 2022-06-22T04:00:45Z

Yes, but maintainers do not have the edit permission, so if you could please fix those 2 issues

stale · 2022-07-31T04:48:56Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

cclauss · 2022-10-01T10:29:07Z

In preparation for that denial-of-service attack that is Hacktoberfest, I am closing all pull requests that have failing tests.

ztick and others added 30 commits February 21, 2022 22:18

feat: issue #1 adds code coverage test for complex function insert_re…

f4b9131

…pair()

feat: issue #2 improves code coverage for insert_repair() from 88% to…

e9b5705

… 100%

Merge pull request #5 from ztick/improve_code_coverage

3e1a6cd

feat: issue #2 improves code coverage for insert_repair() from 88% to…

feat: issue #3 adds test that takes 4 previously untested branches

b50bf90

feat: issue #3 adds a unit test for emptying the tree, which fails wh…

040defe

…en it shouldn't

feat: issue #3 adds test for removing a right-side red child

364f183

Merge pull request #6 from ztick/write_3_additional_tests

aba7053

Write 3 additional tests

feat: issue #4 reduces CCN of insert_repair() by 65%

d6660e5

Merge pull request #7 from ztick/write_3_additional_tests

bf0e082

feat: issue #4 reduces CCN of insert_repair() by 65%

feat: issue #8 adds coverage htmls to showcase improvement

cfda332

Merge pull request #9 from ztick/write_3_additional_tests

4d9520e

feat: issue #8 adds coverage htmls to showcase improvement

fix: added tests to get branch coverage 100%

dae5785

fix: test coverage of queue_on_pseudo_stack.py

d650f95

Fix: added call to doctest in main files.

e4ae92e

Resolving pre-commit-hook changes

d919924

Resolving pre-commit-hook changes

24d7f91

fix: added docstring test for from_sequence

53f5cba

Merge pull request #5 from DD2480-Team/issue/4

6cbb9fa

fix: added docstring test for from_sequence

fix: removed code from main to doctest

faa699a

Merge pull request #7 from DD2480-Team/issue/6

dcc8f22

fix: removed code from main to doctest

fix: added unit tests for is_palindrome.py

df794f1

Merge pull request #9 from DD2480-Team/issue/8

047d5e0

fix: added unit tests for is_palindrome.py

feat: issue #10 improved coverage of red_black_tree.py to 92% (and re…

7225967

…moved non-useful htmls)

fix: issue #10 re-enable a slow test after new tests added

9390832

Merge pull request #11 from ztick/write_3_additional_tests

9be4c68

Increase test coverage of data_structures/binary_tree/red_black_tree.py to 92%

Fixes: #11 improve number_of_possible_binary_trees.py coverage to 100%

64b6478

Also wrap the function, so the function can be triggered by parameters instead of input().

fix: issue #10 adjust documentation according to contribution guidelines

8d3e4c4

Merge pull request #12 from ztick/write_3_additional_tests

5e51e63

fix: issue #10 adjust documentation according to contribution guidelines

feat: issue # 10 expand coverage to 93%

8c3a17f

Adds the last (imo) reasonable test

poyea requested review from cclauss, dhruvmanila, onlinejudge95 and poyea and removed request for dhruvmanila March 16, 2022 15:37

ghost added the tests are failing Do not merge until tests pass label Mar 16, 2022

poyea reviewed Mar 17, 2022

View reviewed changes

stale Bot added the stale Used to mark an issue or pull request stale. label Apr 16, 2022

cclauss reviewed Apr 16, 2022

View reviewed changes

stale Bot removed the stale Used to mark an issue or pull request stale. label Apr 16, 2022

cclauss reviewed Apr 16, 2022

View reviewed changes

cclauss approved these changes Apr 16, 2022

View reviewed changes

ghost removed the awaiting reviews This PR is ready to be reviewed label Apr 16, 2022

stale Bot added the stale Used to mark an issue or pull request stale. label Jun 13, 2022

stale Bot removed the stale Used to mark an issue or pull request stale. label Jun 13, 2022

stale Bot added the stale Used to mark an issue or pull request stale. label Jul 31, 2022

poyea added the help wanted label Sep 14, 2022

stale Bot removed the stale Used to mark an issue or pull request stale. label Sep 14, 2022

cclauss closed this Oct 1, 2022

Uh oh!

Conversation

Dajamante commented Mar 7, 2022

Describe your change:

Checklist:

Uh oh!

poyea Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

poyea Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

poyea Mar 17, 2022

Choose a reason for hiding this comment

Uh oh!

poyea commented Mar 17, 2022

Uh oh!

stale Bot commented Apr 16, 2022

Uh oh!

cclauss Apr 16, 2022

Choose a reason for hiding this comment

Uh oh!

cclauss Apr 16, 2022

Choose a reason for hiding this comment

Uh oh!

cclauss commented Apr 16, 2022

Uh oh!

SnowdenSa commented Apr 16, 2022

Uh oh!

stale Bot commented Jun 13, 2022

Uh oh!

poyea commented Jun 13, 2022

Uh oh!

Dajamante commented Jun 13, 2022

Uh oh!

poyea commented Jun 22, 2022

Uh oh!

stale Bot commented Jul 31, 2022

Uh oh!

cclauss commented Oct 1, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants