Impl socket htonl#1257
Merged
Merged
Conversation
| } | ||
|
|
||
| let host = host.as_bigint().to_u32().unwrap(); | ||
| Ok(vm.new_int(host.to_be())) |
Contributor
There was a problem hiding this comment.
Is there a rust library with the htonl and ntohl functions?
Contributor
Author
There was a problem hiding this comment.
I found htonl and ntohl in socket crate. but it is not very popular.
Contributor
There was a problem hiding this comment.
Okay, maybe stick to this version, until we find a good socket crate. @palaviv do you have any ideas?
Member
There was a problem hiding this comment.
Even from gnu libc, it essentially is this simple of an implementation. Rust's u32::to_be looks basically the same as that libc htonl.
Contributor
|
Hi @SeungUkLee this change looks good! I had one question about using a library for the htonl function. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #1176
Add socket method htonl.