Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(router): Remove deprecated initialNavigation option #45729

Closed
wants to merge 1 commit into from
Closed

fix(router): Remove deprecated initialNavigation option #45729

wants to merge 1 commit into from
+4 −45

Conversation

atscott
Copy link
Contributor

@atscott atscott commented Apr 22, 2022

BREAKING CHANGE:
initialNavigation: 'enabled' was deprecated in v11 and is replaced by
initialNavigation: 'enabledBlocking'.

@atscott atscott added comp: router target: major labels Apr 22, 2022
@atscott atscott requested a review from CaerusKaru Apr 22, 2022
@ngbot ngbot bot added this to the Backlog milestone Apr 22, 2022
@ngbot ngbot bot added this to the Backlog milestone Apr 22, 2022
@atscott atscott force-pushed the removeEnabledInitialNv branch from ac0e8c7 to c05f4a2 Compare Apr 22, 2022
@atscott atscott force-pushed the removeEnabledInitialNv branch from c05f4a2 to f10520f Compare Apr 22, 2022
CaerusKaru
CaerusKaru approved these changes Apr 22, 2022
View changes
Copy link
Member

@CaerusKaru CaerusKaru left a comment

LGTM, thanks!

@atscott
fix(router): Remove deprecated initialNavigation option
59ad136 
BREAKING CHANGE:
`initialNavigation: 'enabled'` was deprecated in v11 and is replaced by
`initialNavigation: 'enabledBlocking'`.
@atscott atscott force-pushed the removeEnabledInitialNv branch from f10520f to 59ad136 Compare Apr 22, 2022
jessicajaniuk
jessicajaniuk approved these changes Apr 25, 2022
View changes
Copy link
Contributor

@jessicajaniuk jessicajaniuk left a comment

reviewed-for: public-api

@atscott atscott removed this from the Backlog milestone Apr 25, 2022
@atscott atscott added this to the v14-candidates milestone Apr 25, 2022
AndrewKushnir
AndrewKushnir approved these changes Apr 27, 2022
View changes
Copy link
Contributor

@AndrewKushnir AndrewKushnir left a comment

Reviewed-for: public-api

dylhunn
dylhunn approved these changes Apr 28, 2022
View changes
Copy link
Contributor

@dylhunn dylhunn left a comment

reviewed-for: public-api

@dylhunn dylhunn added the action: merge label Apr 28, 2022
@dylhunn
Copy link
Contributor

@dylhunn dylhunn commented Apr 28, 2022

This PR was merged into the repository by commit d4fc12f.

@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented May 29, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators May 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CaerusKaru CaerusKaru

@dylhunn dylhunn

@AndrewKushnir AndrewKushnir

@jessicajaniuk jessicajaniuk

@alxhub alxhub

Assignees
No one assigned
Labels
action: merge comp: router flag: breaking change target: major
Projects
None yet
Milestone
v14-candidates
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@atscott @dylhunn @CaerusKaru @AndrewKushnir @jessicajaniuk