Skip to content

ML: add .gitkeep to resources dir in which ML models are to be found#8751

Merged
jhelie merged 1 commit into
mainfrom
jhelie/add-gitkeep-to-model-resources
Apr 25, 2022
Merged

ML: add .gitkeep to resources dir in which ML models are to be found#8751
jhelie merged 1 commit into
mainfrom
jhelie/add-gitkeep-to-model-resources

Conversation

@jhelie
Copy link
Copy Markdown
Contributor

@jhelie jhelie commented Apr 15, 2022

@jhelie jhelie requested a review from a team April 15, 2022 10:19
@annarailton
Copy link
Copy Markdown

This just means the qlpack.yml reference always points to an existing file, right?

Copy link
Copy Markdown
Contributor

@henrymercer henrymercer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it slightly easier for contributors to run ML-powered queries against custom ML models, since the folder to drop ML models into will already exist in the checkout.

@jhelie jhelie merged commit 47fdb79 into main Apr 25, 2022
@jhelie jhelie deleted the jhelie/add-gitkeep-to-model-resources branch April 25, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants