Python: Don't re-export python under DataFlow::#8732
Merged
Conversation
Currently we're not in a good state :(
RasmusWL
force-pushed
the
dataflow-imports
branch
from
cc9e6be to
d70f247
Compare
yoff
approved these changes
May 2, 2022
Contributor
yoff
left a comment
yoff
left a comment
There was a problem hiding this comment.
LGTM
I think it is wise to keep the test, even if it is not strictly needed at the moment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have been trying to do this a few times before, but this problems keeps coming back 😞 so now I added a test to ensure it doesn't.
I think the actual test might not be needed right now, since the code won't compile if you do this again due to the
Unitbeing required from the data-flow implementation.The previous times we've done this we've agreed that this could potentially be a breaking change, but that in reality it shouldn't be a problem, and should just improve code-completions.
Draft PR to check whether this breaks anything else.