Java: Add flow sources and steps for RabbitMQ and JMS by artem-smotrakov · Pull Request #8765 · github/codeql

artem-smotrakov · 2022-04-17T11:37:20Z

This pull request was slpit from #8501 as suggested by @smowton.

In addition, I've added flow sources and steps for JMS API versions 1 and 2 as suggested by @pwntester. The model for the JMS API applis to all JMS implementations such as ActiveMQ and others. However, there may be implementation-specific flow sources and steps that are not covered here. I'd suggest to start with the API and then cover specific implementations if necessary.

Also, added a few flow steps for methods in DataInput and ObjectInput that read byte arrays.

This PR is related to github/securitylab#666

pwntester · 2022-04-18T09:02:49Z

thanks @artem-smotrakov would it make sense to also add deserialization sinks to ObjectMessage.getObject() API as per https://www.blackhat.com/docs/us-16/materials/us-16-Kaiser-Pwning-Your-Java-Messaging-With-Deserialization-Vulnerabilities.pdf

smowton

Haven't reviewed the APIs in general to find additional methods that maybe ought to be modelled, but the changes here seem uncontroverisal

artem-smotrakov · 2022-04-18T11:05:18Z

Hi @smowton Thanks for the comments! I've addressed them.

artem-smotrakov · 2022-04-18T11:13:13Z

thanks @artem-smotrakov would it make sense to also add deserialization sinks to ObjectMessage.getObject() API as per https://www.blackhat.com/docs/us-16/materials/us-16-Kaiser-Pwning-Your-Java-Messaging-With-Deserialization-Vulnerabilities.pdf

@pwntester ObjectMessage.getObject() is an interface method. It depends on implementation if and how it does deserialization. By adding this sink, we'd assume that all implementations do some kind of unsafe deserialization here.

The author of the paper you mentioned says

All ObjectMessage implementations I looked at were deserializing from untrusted input without any validation

Maybe it is a safe assumption. Let me know if this assumption is okay. I don't mind adding this sink though.

pwntester · 2022-04-20T10:31:15Z

Maybe it is a safe assumption. Let me know if this assumption is okay. I don't mind adding this sink though.

I think that after the talk some mitgations were put in place such as the ActiveMQ one so it may require a little testing

artem-smotrakov · 2022-04-24T13:15:38Z

@smowton Unfortunately, I can't see why the checks failed. Could you please check what happened?

atorralba · 2022-04-25T09:13:46Z

First error

File "ql/java/ql/test/stubs/rabbitmq-4.12.0/com/rabbitmq/client/DefaultConsumer.java" contains a non-ASCII character at the location marked with | in:

        
    }

    @Override
    public void handleDelivery|

File "ql/java/ql/test/stubs/rabbitmq-4.12.0/com/rabbitmq/client/Consumer.java" contains a non-ASCII character at the location marked with | in:

ption;;
  
public interface Consumer {
    void handleDelivery|

Second error

--- expected
+++ actual
@@ -1,1 +1,2 @@
-
+| TestIO.java:97:14:97:58 | readLine(...) | Fixed missing result:numTaintFlow=1 |
+| TestIO.java:139:14:139:64 | readUTF(...) | Fixed missing result:numTaintFlow=1 |
Error: [7/8] [114/134 comp 13s eval 6.2s] FAILED(RESULT) ql/java/ql/test/library-tests/frameworks/guava/handwritten/flow.ql

Third error

Error: The following CodeQL elements are lacking documentation:
semmle/code/java/frameworks/JMS.qll  JMS  file

artem-smotrakov · 2022-04-25T21:34:11Z

Thanks for the info @atorralba ! I hope the errors are now fixed. Could you please rerun the checks?

github-actions · 2022-04-26T06:34:24Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    Java Standard Library,``java.*``,3,541,115,28,,,7,,,10
+    Java Standard Library,``java.*``,3,545,115,28,,,7,,,10
-    Java extensions,"``javax.*``, ``jakarta.*``",54,552,32,,,4,,1,1,2
+    Java extensions,"``javax.*``, ``jakarta.*``",63,609,32,,,4,,1,1,2
-    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",44,283,929,,,,14,18,,
+    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.rabbitmq.client``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",65,290,929,,,,14,18,,
-    Totals,,183,6233,1441,106,6,10,107,33,1,81
+    Totals,,213,6301,1441,106,6,10,107,33,1,81

Changes to framework-coverage-java.csv:

+ com.rabbitmq.client,,21,7,,,,,,,,,,,,,,,,,,,,,,,,,,21,7,
- java.io,37,,31,,15,,,,,,,,,,,,,,,,,,22,,,,,,,31,
+ java.io,37,,35,,15,,,,,,,,,,,,,,,,,,22,,,,,,,35,
+ javax.jms,,9,57,,,,,,,,,,,,,,,,,,,,,,,,,,9,57,

github-advanced-security

Found 1 vulnerability.

github-actions · 2022-04-26T11:20:43Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    Java Standard Library,``java.*``,3,541,115,28,,,7,,,10
+    Java Standard Library,``java.*``,3,545,115,28,,,7,,,10
-    Java extensions,"``javax.*``, ``jakarta.*``",54,552,32,,,4,,1,1,2
+    Java extensions,"``javax.*``, ``jakarta.*``",63,609,32,,,4,,1,1,2
-    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",44,283,929,,,,14,18,,
+    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.rabbitmq.client``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",65,290,929,,,,14,18,,
-    Totals,,183,6233,1441,106,6,10,107,33,1,81
+    Totals,,213,6301,1441,106,6,10,107,33,1,81

Changes to framework-coverage-java.csv:

+ com.rabbitmq.client,,21,7,,,,,,,,,,,,,,,,,,,,,,,,,,21,7,
- java.io,37,,31,,15,,,,,,,,,,,,,,,,,,22,,,,,,,31,
+ java.io,37,,35,,15,,,,,,,,,,,,,,,,,,22,,,,,,,35,
+ javax.jms,,9,57,,,,,,,,,,,,,,,,,,,,,,,,,,9,57,

Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>

Co-authored-by: Chris Smowton <smowton@github.com>

Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>

smowton

@aschackmull is this ok with you with the import fixed as asked?

github-actions · 2022-04-26T12:37:00Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    Java Standard Library,``java.*``,3,541,115,28,,,7,,,10
+    Java Standard Library,``java.*``,3,545,115,28,,,7,,,10
-    Java extensions,"``javax.*``, ``jakarta.*``",54,552,32,,,4,,1,1,2
+    Java extensions,"``javax.*``, ``jakarta.*``",63,609,32,,,4,,1,1,2
-    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",44,283,929,,,,14,18,,
+    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.rabbitmq.client``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",65,290,929,,,,14,18,,
-    Totals,,183,6233,1441,106,6,10,107,33,1,81
+    Totals,,213,6301,1441,106,6,10,107,33,1,81

Changes to framework-coverage-java.csv:

+ com.rabbitmq.client,,21,7,,,,,,,,,,,,,,,,,,,,,,,,,,21,7,
- java.io,37,,31,,15,,,,,,,,,,,,,,,,,,22,,,,,,,31,
+ java.io,37,,35,,15,,,,,,,,,,,,,,,,,,22,,,,,,,35,
+ javax.jms,,9,57,,,,,,,,,,,,,,,,,,,,,,,,,,9,57,

aschackmull · 2022-04-27T11:42:09Z

@aschackmull is this ok with you with the import fixed as asked?

Change note possibly needs to be in lib rather than src. Otherwise yes, no further comments from me.

github-actions · 2022-04-27T14:03:41Z

⚠️ The head of this PR and the base branch were compared for differences in the framework coverage reports. The generated reports are available in the artifacts of this workflow run. The differences will be picked up by the nightly job after the PR gets merged.

Click to show differences in coverage

java

Generated file changes for java

Changes to framework-coverage-java.rst:

-    Java Standard Library,``java.*``,3,541,115,28,,,7,,,10
+    Java Standard Library,``java.*``,3,545,115,28,,,7,,,10
-    Java extensions,"``javax.*``, ``jakarta.*``",54,552,32,,,4,,1,1,2
+    Java extensions,"``javax.*``, ``jakarta.*``",63,609,32,,,4,,1,1,2
-    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",44,283,929,,,,14,18,,
+    Others,"``androidx.slice``, ``cn.hutool.core.codec``, ``com.esotericsoftware.kryo.io``, ``com.esotericsoftware.kryo5.io``, ``com.fasterxml.jackson.core``, ``com.fasterxml.jackson.databind``, ``com.opensymphony.xwork2.ognl``, ``com.rabbitmq.client``, ``com.unboundid.ldap.sdk``, ``com.zaxxer.hikari``, ``flexjson``, ``groovy.lang``, ``groovy.util``, ``jodd.json``, ``net.sf.saxon.s9api``, ``ognl``, ``org.apache.commons.codec``, ``org.apache.commons.jexl2``, ``org.apache.commons.jexl3``, ``org.apache.commons.logging``, ``org.apache.commons.ognl``, ``org.apache.directory.ldap.client.api``, ``org.apache.ibatis.jdbc``, ``org.apache.log4j``, ``org.apache.logging.log4j``, ``org.apache.shiro.codec``, ``org.apache.shiro.jndi``, ``org.codehaus.groovy.control``, ``org.dom4j``, ``org.hibernate``, ``org.jboss.logging``, ``org.jdbi.v3.core``, ``org.jooq``, ``org.mvel2``, ``org.scijava.log``, ``org.slf4j``, ``org.xml.sax``, ``org.xmlpull.v1``, ``play.mvc``, ``ratpack.core.form``, ``ratpack.core.handling``, ``ratpack.core.http``, ``ratpack.exec``, ``ratpack.form``, ``ratpack.func``, ``ratpack.handling``, ``ratpack.http``, ``ratpack.util``",65,290,929,,,,14,18,,
-    Totals,,183,6233,1441,106,6,10,107,33,1,81
+    Totals,,213,6301,1441,106,6,10,107,33,1,81

Changes to framework-coverage-java.csv:

+ com.rabbitmq.client,,21,7,,,,,,,,,,,,,,,,,,,,,,,,,,21,7,
- java.io,37,,31,,15,,,,,,,,,,,,,,,,,,22,,,,,,,31,
+ java.io,37,,35,,15,,,,,,,,,,,,,,,,,,22,,,,,,,35,
+ javax.jms,,9,57,,,,,,,,,,,,,,,,,,,,,,,,,,9,57,

artem-smotrakov · 2022-04-27T20:46:51Z

Thanks for the review and addressing the comments @smowton !

artem-smotrakov requested a review from a team as a code owner April 17, 2022 11:37

github-actions Bot added documentation Java labels Apr 17, 2022

artem-smotrakov mentioned this pull request Apr 17, 2022

Java: Delayed unsafe deserialization #8501

Closed

artem-smotrakov changed the title ~~Add flow sources and steps for RabbitMQ and JMS~~ Java: Add flow sources and steps for RabbitMQ and JMS Apr 17, 2022

artem-smotrakov mentioned this pull request Apr 17, 2022

[Java]: Delayed unsafe deserialization github/securitylab#556

Closed

2 tasks

smowton reviewed Apr 18, 2022

View reviewed changes

Comment thread java/ql/lib/semmle/code/java/frameworks/JMS.qll Outdated

Comment thread java/ql/src/change-notes/2022-04-17-jms.md Outdated

Comment thread java/ql/test/library-tests/frameworks/jms/FlowTest.ql Outdated

Comment thread java/ql/lib/semmle/code/java/dataflow/FlowSteps.qll Outdated

artem-smotrakov mentioned this pull request Apr 18, 2022

[Java]: Flow sources and steps for JMS and RabbitMQ github/securitylab#666

Closed

2 tasks

github-advanced-security AI found potential problems Apr 26, 2022

View reviewed changes

Comment thread java/ql/lib/semmle/code/java/frameworks/JMS.qll Fixed

smowton previously approved these changes Apr 26, 2022

View reviewed changes

aschackmull reviewed Apr 26, 2022

View reviewed changes

Comment thread java/ql/lib/semmle/code/java/frameworks/JMS.qll Outdated

smowton dismissed their stale review via d5e7a47 April 26, 2022 12:31

artem-smotrakov and others added 9 commits April 26, 2022 13:32

Java: Added flow steps for DataInput and ObjectInput

fb39e0f

Java: Added sources and flow steps for RabbitMQ

269143a

Fixed model for DataInput

5c6aa15

Co-authored-by: Marcono1234 <Marcono1234@users.noreply.github.com>

Added sources and steps for JMS API

b6bd4f9

Added a change note for JMS

152de15

minorAnalysis in 2022-04-17-jms.md

7158fd1

Co-authored-by: Chris Smowton <smowton@github.com>

Use tainted tag in JMS tests

20f185e

Fixed typos in JMS.qll

d7ad13b

Removed RabbitMQ import in FlowSteps.qll

3369ffc

artem-smotrakov and others added 6 commits April 26, 2022 13:34

Moved RabbitMQ tests to java/ql/test/library-tests/frameworks/rabbitmq

e86fd72

Removed non-ASCII characters

52b7fbf

Fixed library-tests/frameworks/guava/handwritten/flow.ql

12ca1f0

Use doc-comment in JMS.qll

03d8630

Replace singleton set

c0c5014

Make import private

d01c847

Co-authored-by: Anders Schack-Mulligen <aschackmull@users.noreply.github.com>

smowton force-pushed the cover-jms branch from d5e7a47 to d01c847 Compare April 26, 2022 12:34

smowton previously approved these changes Apr 26, 2022

View reviewed changes

Move change note

db90bf9

smowton dismissed their stale review via db90bf9 April 27, 2022 14:00

smowton approved these changes Apr 27, 2022

View reviewed changes

smowton merged commit bb049bf into github:main Apr 27, 2022

artem-smotrakov deleted the cover-jms branch April 27, 2022 20:46

Conversation

artem-smotrakov commented Apr 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pwntester commented Apr 18, 2022

Uh oh!

smowton left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

artem-smotrakov commented Apr 18, 2022

Uh oh!

artem-smotrakov commented Apr 18, 2022

Uh oh!

pwntester commented Apr 20, 2022

Uh oh!

artem-smotrakov commented Apr 24, 2022

Uh oh!

atorralba commented Apr 25, 2022

First error

Second error

Third error

Uh oh!

artem-smotrakov commented Apr 25, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 26, 2022

java

Generated file changes for java

Uh oh!

github-advanced-security AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 26, 2022

java

Generated file changes for java

Uh oh!

Uh oh!

smowton left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Apr 26, 2022

java

Generated file changes for java

Uh oh!

aschackmull commented Apr 27, 2022

Uh oh!

github-actions Bot commented Apr 27, 2022

java

Generated file changes for java

Uh oh!

artem-smotrakov commented Apr 27, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

artem-smotrakov commented Apr 17, 2022 •

edited

Loading

artem-smotrakov commented Apr 25, 2022 •

edited

Loading