Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Windows build to use xz-5.2.5 #85036

Open
animalize mannequin opened this issue Jun 4, 2020 · 2 comments
Open

Update Windows build to use xz-5.2.5 #85036

animalize mannequin opened this issue Jun 4, 2020 · 2 comments
Labels
3.9 3.10 OS-windows

Comments

@animalize
Copy link
Mannequin

@animalize animalize mannequin commented Jun 4, 2020

BPO 40859
Nosy @pfmoore, @tjguk, @zware, @zooba, @animalize
PRs
  • #20622
    		•

    Note: these values reflect the state of the issue at the time it was migrated and might not reflect the current state.

    Show more details

    GitHub fields:

    assignee = None
closed_at = None
created_at = <Date 2020-06-04.02:41:03.855>
labels = ['3.10', '3.9', 'OS-windows']
title = 'Update Windows build to use xz-5.2.5'
updated_at = <Date 2020-06-04.02:44:37.373>
user = 'https://github.com/animalize'

    bugs.python.org fields:

    activity = <Date 2020-06-04.02:44:37.373>
actor = 'malin'
assignee = 'none'
closed = False
closed_date = None
closer = None
components = ['Windows']
creation = <Date 2020-06-04.02:41:03.855>
creator = 'malin'
dependencies = []
files = []
hgrepos = []
issue_num = 40859
keywords = ['patch']
message_count = 1.0
messages = ['370693']
nosy_count = 5.0
nosy_names = ['paul.moore', 'tim.golden', 'zach.ware', 'steve.dower', 'malin']
pr_nums = ['20622']
priority = 'normal'
resolution = None
stage = 'patch review'
status = 'open'
superseder = None
type = None
url = 'https://bugs.python.org/issue40859'
versions = ['Python 3.9', 'Python 3.10']
    @animalize
    Copy link
    Mannequin Author

    @animalize animalize mannequin commented Jun 4, 2020

    The Windows build is using xz-5.2.2, it was released on 2015-09-29.
    xz-5.2.5 was released recently, maybe we can update this library.

    When preparing cpython-source-deps, don't forget to copy xz-5.2.5\windows\vs2019\config.h to xz-5.2.5\windows\ folder.

    \vs2019\config.h and \vs2017\config.h are the same, except for the comment on the first line.

    I tested xz-5.2.5 on my local machine, it passed test_lzma.py.

    XZ Utils Release Notes:
    https://git.tukaani.org/?p=xz.git;a=blob;f=NEWS;hb=HEAD

    @ezio-melotti ezio-melotti transferred this issue from another repository Apr 10, 2022
    @gpshead
    Copy link
    Member

    @gpshead gpshead commented Apr 16, 2022

    this seem useful, but apparently something more than what is in that PR needs to be done for it to work.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Assignees
    No one assigned
    Labels
    3.9 3.10 OS-windows
    Projects
    Compression issues
    Status: No status
    Milestone
    No milestone
    Development

    No branches or pull requests
    1 participant
    @gpshead