Skip to content

make sure there is no pytest where it should not be #6563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ThomasWaldmann opened this issue Apr 10, 2022 · 0 comments
Closed

make sure there is no pytest where it should not be #6563

ThomasWaldmann opened this issue Apr 10, 2022 · 0 comments
Assignees
@ThomasWaldmann
Labels
easy good first issue
Milestone
2.0.0a2

Comments

@ThomasWaldmann
Copy link
Member

ThomasWaldmann commented Apr 10, 2022 •
edited
Loading

some tests are run as part of the borg self test which is executed at every start of borg.

as borg does not and must not require pytest for a normal installation, these tests must not use pytest.

there is a comment in the relevant test files (e.g. some crypto tests), but it is easy to miss.

guess we better add an assert checking that there is no pytest in the module namespace for all modules used in that way.
@ThomasWaldmann ThomasWaldmann added this to the 1.3.0b1 milestone Apr 10, 2022
@ThomasWaldmann ThomasWaldmann modified the milestones: 1.3.0b1, 1.3.0a2 Apr 14, 2022
@ThomasWaldmann ThomasWaldmann self-assigned this May 6, 2022
ThomasWaldmann added a commit that referenced this issue May 7, 2022
@ThomasWaldmann
Merge pull request #6670 from ThomasWaldmann/no-pytest-check-master
4acfcf2 
check that borg does not require pytest for normal usage, fixes #6563
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ThomasWaldmann ThomasWaldmann

Labels
easy good first issue
Projects
None yet
Milestone
2.0.0a2
Development

No branches or pull requests
1 participant
@ThomasWaldmann