Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-82849: revise intro to os.path.rst #32232

Merged
merged 3 commits into from Apr 16, 2022

Conversation

Copy link
Contributor

@jdevries3133 jdevries3133 commented Apr 1, 2022

  • revise the first paragraph of docs for os.path
  • add a mention of os.PathLike protocol
  • remove warnings rendered irrelevant by pep 383 and pep 529

#82849

https://bugs.python.org/issue38668

* revise the first paragraph of docs for os.path
* add a mention of `os.PathLike` protocol
* remove warnings rendered irrelevant by pep 383 and pep 529
@bedevere-bot bedevere-bot added the docs label Apr 1, 2022
@lazka
Copy link
Contributor

@lazka lazka commented Apr 1, 2022

LGTM 👍

(I'm obviously biased here since I suggested these changes in the linked bug report 😁)

@JelleZijlstra JelleZijlstra changed the title bpo-38668(doc): revise intro to os.path.rst gh-82849: revise intro to os.path.rst Apr 15, 2022
@JelleZijlstra JelleZijlstra self-assigned this Apr 15, 2022
@JelleZijlstra JelleZijlstra merged commit 468314c into python:main Apr 16, 2022
13 checks passed
@miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Apr 16, 2022

Thanks @jdevries3133 for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒🤖

miss-islington added a commit to miss-islington/cpython that referenced this issue Apr 16, 2022
* revise the first paragraph of docs for os.path
* add a mention of `os.PathLike` protocol
* remove warnings rendered irrelevant by :pep:`383` and :pep:`529`

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 468314cc8bfdb6fd328cbbbb7d0807728f25e043)

Co-authored-by: Jack DeVries <jdevries3133@gmail.com>
@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 16, 2022

GH-91592 is a backport of this pull request to the 3.10 branch.

@bedevere-bot
Copy link

@bedevere-bot bedevere-bot commented Apr 16, 2022

GH-91593 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this issue Apr 16, 2022
* revise the first paragraph of docs for os.path
* add a mention of `os.PathLike` protocol
* remove warnings rendered irrelevant by :pep:`383` and :pep:`529`

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 468314c)

Co-authored-by: Jack DeVries <jdevries3133@gmail.com>
miss-islington added a commit that referenced this issue Apr 16, 2022
* revise the first paragraph of docs for os.path
* add a mention of `os.PathLike` protocol
* remove warnings rendered irrelevant by :pep:`383` and :pep:`529`

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
(cherry picked from commit 468314c)

Co-authored-by: Jack DeVries <jdevries3133@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA signed docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants