Skip to content

Dataflow: Revert support for flow-state based in-/out-barriers#8703

Merged
aschackmull merged 3 commits into
github:mainfrom
aschackmull:dataflow/revert-state-in-out-barriers
Apr 20, 2022
Merged

Dataflow: Revert support for flow-state based in-/out-barriers#8703
aschackmull merged 3 commits into
github:mainfrom
aschackmull:dataflow/revert-state-in-out-barriers

Conversation

@aschackmull
Copy link
Copy Markdown
Contributor

@aschackmull aschackmull commented Apr 8, 2022

Resolves #8435 (comment)

@aschackmull aschackmull requested review from a team as code owners April 8, 2022 11:55
@aschackmull
Copy link
Copy Markdown
Contributor Author

aschackmull commented Apr 8, 2022

Depends on #8702

jketema
jketema reviewed Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jketema jketema left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, and note that #8702 needs to be merged first (awaiting completion of DCA experiment). Otherwise, LGTM.

Comment thread cpp/ql/lib/change-notes/2022-03-14-flow-state-barriers.md Outdated
@aschackmull aschackmull force-pushed the dataflow/revert-state-in-out-barriers branch from 8f0f10a to e837916 Compare April 8, 2022 12:36
jketema
jketema requested changes Apr 8, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per change note documentation

Comment thread cpp/ql/lib/change-notes/2022-04-08-flow-state-barriers.md
Comment thread csharp/ql/lib/change-notes/2022-04-08-flow-state-barriers.md
Comment thread java/ql/lib/change-notes/2022-04-08-flow-state-barriers.md
Comment thread python/ql/lib/change-notes/2022-04-08-flow-state-barriers.md
Comment thread ruby/ql/lib/change-notes/2022-04-08-flow-state-barriers.md
jketema
jketema previously approved these changes Apr 8, 2022
View reviewed changes
@geoffw0
Copy link
Copy Markdown
Contributor

geoffw0 commented Apr 11, 2022

What's the story here? I'm using isBarrierOut(DataFlow::Node node, string flowstate) in an upcoming PR.

@MathiasVP
Copy link
Copy Markdown
Contributor

MathiasVP commented Apr 11, 2022

What's the story here? I'm using isBarrierOut(DataFlow::Node node, string flowstate) in an upcoming PR.

It turns out that this is too difficult to implement correctly. See the conversation linked in the PR description: #8435 (comment)

@geoffw0
Copy link
Copy Markdown
Contributor

geoffw0 commented Apr 11, 2022

I think I can get by using isBarrier(Node node, FlowState state), with probably little or no loss of accuracy. Is that the right approach?

@MathiasVP
Copy link
Copy Markdown
Contributor

MathiasVP commented Apr 11, 2022

I think I can get by using isBarrier(Node node, FlowState state), with probably little or no loss of accuracy. Is that the right approach?

isBarrier(node, state) isn't going anywhere, no. I can't tell whether it's the right approach (since I don't know what your use-case is!), but it's definitely an API that's supported by the dataflow library.

@jketema
Copy link
Copy Markdown
Contributor

jketema commented Apr 14, 2022

@aschackmull #8702 has been merged. I'm not sure if you want to rebase this to get all the tests green or not, so I leave merging of this PR to you.

@geoffw0 geoffw0 mentioned this pull request Apr 14, 2022
Merged
4 tasks
@aschackmull aschackmull force-pushed the dataflow/revert-state-in-out-barriers branch from 25f0e9f to 48fbbf2 Compare April 19, 2022 13:30
@aschackmull
Copy link
Copy Markdown
Contributor Author

aschackmull commented Apr 19, 2022

@aschackmull #8702 has been merged. I'm not sure if you want to rebase this to get all the tests green or not, so I leave merging of this PR to you.

Thanks, I've rebased the PR.

@aschackmull aschackmull merged commit 677c436 into github:main Apr 20, 2022
@aschackmull aschackmull deleted the dataflow/revert-state-in-out-barriers branch April 20, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jketema jketema jketema approved these changes

Assignees

No one assigned

Labels

C# C++ DataFlow Library documentation Java Python Ruby

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aschackmull @geoffw0 @MathiasVP @jketema @owen-mc