Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce cpu explicitly for Mac devicelab test beds #101871

Merged
merged 2 commits into from Apr 15, 2022
Merged

Enforce cpu explicitly for Mac devicelab test beds #101871

merged 2 commits into from Apr 15, 2022
+3 −1

Conversation

keyonghan
Copy link
Contributor

@keyonghan keyonghan commented Apr 13, 2022

All existing devicelab testbeds are Macmini8,1 now, but from tests config side, we are not enforcing the mac_model.

On the other hand, we are enabling M1 tests and M1 bots in prod, this will cause existing Mac devicelab tests to run against M1 bots. However, not all tests are supported on M1 bots.

This PR tags mac_model: Macmini8,1 explicitly to avoid interaction between test beds. This will also help avoid potential breakage when model changes in the future.

Context: #101861

@keyonghan keyonghan requested review from godofredoc and jmagman Apr 13, 2022
@jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2022

Is there any way we can tag gpu:Intel instead since that's what we really care about here? We don't want to limit to a model if, say, half our ARM fleet are Mac Minis from last year and the other half are Mac Mini models from this year.

@keyonghan
Copy link
Contributor Author

@keyonghan keyonghan commented Apr 14, 2022 •
edited

Is there any way we can tag gpu:Intel instead since that's what we really care about here? We don't want to limit to a model if, say, half our ARM fleet are Mac Minis from last year and the other half are Mac Mini models from this year.

Gpu tag for arm Mac is blocked on: https://bugs.chromium.org/p/chromium/issues/detail?id=1109628
Does it make sense we use the mac_model for now and update to gpu when that is supported?

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2022

That issue says we can use cpu:arm-64, does that work?

@keyonghan
Copy link
Contributor Author

@keyonghan keyonghan commented Apr 14, 2022

That issue says we can use cpu:arm-64, does that work?

Arm bots show cpu: arm64, but intel bots show cpu: x86. Is it suffice for intel bots?

@jmagman
Copy link
Member

@jmagman jmagman commented Apr 14, 2022

That issue says we can use cpu:arm-64, does that work?

Arm bots show cpu: arm64, but intel bots show cpu: x86. Is it suffice for intel bots?

Yes, that's the distinction we need!

@keyonghan keyonghan mentioned this pull request Apr 14, 2022
Merged
@keyonghan
Copy link
Contributor Author

@keyonghan keyonghan commented Apr 14, 2022 •
edited

flutter/cocoon#1731 and https://flutter-review.googlesource.com/c/infra/+/29061 to support cpu dimension defined in .ci.yaml.

@keyonghan keyonghan changed the title Enforce mac_model explicitly for Mac devicelab test beds Enforce cpu explicitly for Mac devicelab test beds Apr 15, 2022
@keyonghan
Copy link
Contributor Author

@keyonghan keyonghan commented Apr 15, 2022

Updated all Mac builders to use cpu: x86. This should not affect existing workflows, as of now mac_model: Macmini8,1 is equal to cpu: x86.

But will land this PR after flutter/cocoon#1731 is pushed to latest cocoon version.

jmagman
jmagman approved these changes Apr 15, 2022
View changes
Copy link
Member

@jmagman jmagman left a comment

LGTM, thanks @keyonghan!

@keyonghan keyonghan added the waiting for tree to go green label Apr 15, 2022
@fluttergithubbot fluttergithubbot merged commit 7d2d63c into flutter:master Apr 15, 2022
111 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2022
Closed
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 15, 2022
@engine-flutter-autoroll
7d2d63c90 Enforce cpu explicitly for Mac devicelab test beds (flutter…
e3df41e 
…/flutter#101871)
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Apr 15, 2022
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/plugins that referenced this issue Apr 15, 2022
@engine-flutter-autoroll
7d2d63c90 Enforce cpu explicitly for Mac devicelab test beds (flutter…
f1847ad 
…/flutter#101871)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmagman jmagman

@godofredoc godofredoc

Assignees
No one assigned
Labels
waiting for tree to go green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@keyonghan @jmagman @fluttergithubbot