`DatabaseHandles' in ethconfig.Config cannot be set through TOML #24148

barwod · 2021-12-22T15:10:34Z

System information

Geth
Version: 1.10.13-stable
Git Commit: 7a0c19f
Architecture: amd64
Go Version: go1.17.3
Operating System: linux
GOPATH=
GOROOT=go

Expected behaviour

Close files that aren't in use / have a settable limit

Actual behaviour

Every database file it opens stays open for the duration of the sync

Steps to reproduce the behaviour

Snap sync the blockchain on an AWS EFS volume

Backtrace

I use @holiman recomendation from issue #23922
but i get error:

"Fatal: /root/.ethereum/config.toml, line 13: field corresponding to `DatabaseHandles' in ethconfig.Config cannot be set through TOML"

My config.toml:

[Eth]
NetworkId = 4
SyncMode = "snap"
EthDiscoveryURLs = ["enrtree://AKA3AM6LPBYEUDMVNU3BSVQJ5AD45Y7YPOHJLEF6W26QOE4VTUDPE@all.rinkeby.ethdisco.net"]
SnapDiscoveryURLs = ["enrtree://AKA3AM6LPBYEUDMVNU3BSVQJ5AD45Y7YPOHJLEF6W26QOE4VTUDPE@all.rinkeby.ethdisco.net"]
NoPruning = false
NoPrefetch = false
TxLookupLimit = 2350000
LightPeers = 100
UltraLightFraction = 75
DatabaseCache = 512
DatabaseFreezer = ""
DatabaseHandles = 30000
TrieCleanCache = 154
TrieCleanCacheJournal = "triecache"
TrieCleanCacheRejournal = 3600000000000
TrieDirtyCache = 256
TrieTimeout = 3600000000000
SnapshotCache = 102
Preimages = false
EnablePreimageRecording = false
RPCGasCap = 50000000
RPCEVMTimeout = 5000000000
RPCTxFeeCap = 1e+00

Any idea how to fix this?

The text was updated successfully, but these errors were encountered:

ligi · 2022-01-13T10:19:24Z

thanks - seems we need to add it to the TOML - as a workaround you can set it via CLI

barwod · 2022-01-13T10:44:46Z

How? Could you please provide this command here?

kkosowsk · 2022-01-14T12:41:10Z

hello, I have the same problem, but I don't see an option to set this parameter via CLI?

holiman · 2022-01-14T13:32:19Z

RIght, no that's true, it's not settabie, not via config nor cli. It's calculated on the fly,

holiman · 2022-01-14T13:34:33Z

I think a valid solution would be, not to set the max database handles explicitly, but rather to override the max file limit. So instead of geth checking the max file limit and deriving the db handle limit from that, we'd check use the smallest of fdlimit and override_fd_limit and use that to derive the db handle limit.

eval-exec · 2022-02-12T08:52:43Z

I think a valid solution would be, not to set the max database handles explicitly, but rather to override the max file limit. So instead of geth checking the max file limit and deriving the db handle limit from that, we'd check use the smallest of fdlimit and override_fd_limit and use that to derive the db handle limit.

Hello holiman, I would like to solve this issue.
I found DatabaseHandles was set by MakeDatabaseHandles() at here:

go-ethereum/cmd/utils/flags.go

Lines 1058 to 1070 in fb3a652

    
           // MakeDatabaseHandles raises out the number of allowed file handles per process 
        
           // for Geth and returns half of the allowance to assign to the database. 
        
           func MakeDatabaseHandles() int { 
        
           	limit, err := fdlimit.Maximum() 
        
           	if err != nil { 
        
           		Fatalf("Failed to retrieve file descriptor allowance: %v", err) 
        
           	} 
        
           	raised, err := fdlimit.Raise(uint64(limit)) 
        
           	if err != nil { 
        
           		Fatalf("Failed to raise file descriptor allowance: %v", err) 
        
           	} 
        
           	return int(raised / 2) // Leave half for networking and other stuff 
        
           }

but, how can I derive the db handle limit from the smallest of fdlimit and override_fd_limit ?
I think the smallest fdlimit of a process is uncertain.

joaoepj · 2022-02-17T19:19:41Z

but, how can I derive the db handle limit from the smallest of fdlimit and override_fd_limit ?
I think the smallest fdlimit of a process is uncertain.

@eval-exec , I think this issue only arises on very busy nodes running under restricted enviroments like AWS. Using the minimum value between limit and DatabaseHandles as argument to fdlimit.Raise() would suffice to avoid the postponed filesystem errors. In the other hand, geth should free file descriptors as soon as possible.

…ereum#24148)

) :

)

* eth, cmd: allow FdLimit to be set in config/command line (#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com>

* eth, cmd: allow FdLimit to be set in config/command line (ethereum#24148) * eth/ethconfig: format code * cmd, eth/ethconfig: simplify fdlimit arg, disallow toml * cnd/utils: make fdlimit setting nicer on the logs Co-authored-by: Gary Rong <garyrong0905@gmail.com> Co-authored-by: Péter Szilágyi <peterke@gmail.com>

barwod added the type:bug label Dec 22, 2021

ligi added the status:triage label Jan 4, 2022

ligi changed the title ~~Unable to sync a blockchain on AWS EFS as it has a hard limit of 32k open files~~ `DatabaseHandles' in ethconfig.Config cannot be set through TOML Jan 13, 2022

ligi removed the status:triage label Jan 20, 2022

MariusVanDerWijden assigned MariusVanDerWijden and unassigned MariusVanDerWijden Jan 20, 2022

MariusVanDerWijden added good first issue help wanted labels Jan 20, 2022

This comment was marked as spam.

Sign in to view

ohe added a commit to ohe/go-ethereum that referenced this issue Feb 27, 2022

eth, cmd: allow DatabaseHandles to be set in config/command line (eth…

32f08b5

…ereum#24148)

ohe mentioned this issue Feb 27, 2022

Allow file descriptor limit to be set via CLI #24477

Merged

ohe added a commit to ohe/go-ethereum that referenced this issue Feb 28, 2022

eth, cmd: allow FdLimit to be set in config/command line (ethereum#24148

349ae49

) :

ohe added a commit to ohe/go-ethereum that referenced this issue Feb 28, 2022

eth, cmd: allow FdLimit to be set in config/command line (ethereum#24148

c6320c9

)

ethereum / go-ethereum Public

`DatabaseHandles' in ethconfig.Config cannot be set through TOML #24148

`DatabaseHandles' in ethconfig.Config cannot be set through TOML #24148

barwod commented Dec 22, 2021 •

edited by rjl493456442

ligi commented Jan 13, 2022

barwod commented Jan 13, 2022

kkosowsk commented Jan 14, 2022

holiman commented Jan 14, 2022

holiman commented Jan 14, 2022

This comment was marked as spam.

eval-exec commented Feb 12, 2022 •

edited

joaoepj commented Feb 17, 2022

ethereum / go-ethereum Public

`DatabaseHandles' in ethconfig.Config cannot be set through TOML #24148

`DatabaseHandles' in ethconfig.Config cannot be set through TOML #24148

Comments

barwod commented Dec 22, 2021 • edited by rjl493456442

System information

Expected behaviour

Actual behaviour

Steps to reproduce the behaviour

Backtrace

ligi commented Jan 13, 2022

barwod commented Jan 13, 2022

kkosowsk commented Jan 14, 2022

holiman commented Jan 14, 2022

holiman commented Jan 14, 2022

This comment was marked as spam.

eval-exec commented Feb 12, 2022 • edited

joaoepj commented Feb 17, 2022

barwod commented Dec 22, 2021 •

edited by rjl493456442

eval-exec commented Feb 12, 2022 •

edited