Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(devtools): adding firefox support #44952

Closed
wants to merge 10 commits into from
Closed

feat(devtools): adding firefox support #44952

wants to merge 10 commits into from

Conversation

sumitarora
Copy link
Contributor

@sumitarora sumitarora commented Feb 2, 2022 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #44945

Does this PR introduce a breaking change?

  • Yes
  • No

@ngbot ngbot bot added this to the Backlog milestone Feb 2, 2022
@pullapprove pullapprove bot requested a review from devversion Feb 2, 2022
@devversion devversion requested a review from mgechev Feb 3, 2022
devversion
devversion approved these changes Feb 3, 2022
View changes
Copy link
Member

@devversion devversion left a comment

LGTM for the bazel setup. Would be good to also preserve trailing newlines for consistency.

devtools/projects/shell-chrome/src/manifest/BUILD.bazel Outdated Show resolved Hide resolved
devtools/projects/shell-chrome/src/BUILD.bazel Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Feb 3, 2022
View changes
devtools/docs/firefox.md Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Feb 3, 2022
View changes
devtools/docs/firefox.md Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Feb 3, 2022
View changes
devtools/docs/firefox.md Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Feb 3, 2022
View changes
devtools/docs/firefox.md Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Feb 3, 2022
View changes
devtools/docs/firefox.md Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Feb 3, 2022
View changes
devtools/docs/firefox.md Outdated Show resolved Hide resolved
mgechev
mgechev requested changes Feb 3, 2022
View changes
Copy link
Member

@mgechev mgechev left a comment

Mostly looks good to me. Left a few suggestions.

@sumitarora sumitarora force-pushed the feature/firefox branch 2 times, most recently from c69bc4b to 2fc87d7 Compare Feb 14, 2022
mgechev
mgechev reviewed Feb 14, 2022
View changes
package.json Outdated Show resolved Hide resolved
@sumitarora sumitarora force-pushed the feature/firefox branch 8 times, most recently from b8e1638 to 8634e49 Compare Feb 18, 2022
@sumitarora
Copy link
Author

@sumitarora sumitarora commented Feb 18, 2022

@mgechev @devversion Updated PR with all the changes. Should be good to review.

@devversion devversion requested a review from mgechev Feb 19, 2022
devversion
devversion reviewed Feb 19, 2022
View changes
package.json Outdated Show resolved Hide resolved
mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/README.md Show resolved Hide resolved
mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/docs/firefox.md Outdated
@@ -0,0 +1,15 @@
# Installing Angular DevTools in Firefox

To install Angular DevTools in Firefox follow the steps:-
Copy link
Member

@mgechev mgechev Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
To install Angular DevTools in Firefox follow the steps:-
To install Angular DevTools in Firefox follow the steps:

mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/docs/firefox.md Outdated

* Click on `Load Temporary Add-on` button to select and load the Angular DevTools extension for Firefox.

* Select any file from `dist/bin/devtools/projects/shell-browser/src/prodapp` directory to load extension. If you have not built the extension for Firefox yet. You can do it using `yarn devtools:build:firefox` which will generate build for Firefox.
Copy link
Member

@mgechev mgechev Apr 11, 2022 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Select any file from `dist/bin/devtools/projects/shell-browser/src/prodapp` directory to load extension. If you have not built the extension for Firefox yet. You can do it using `yarn devtools:build:firefox` which will generate build for Firefox.
* Select any file from `dist/bin/devtools/projects/shell-browser/src/prodapp` directory to load extension. If you have not built the extension for Firefox yet, you can do it using `yarn devtools:build:firefox` which will generate build for Firefox.

mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/projects/shell-browser/src/popups/not-angular.html
</div>
</body>

</html>
Copy link
Member

@mgechev mgechev Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't open <html> anywhere.

mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/projects/shell-browser/src/popups/not-angular.html
@@ -0,0 +1,60 @@
<!DOCTYPE html>

Copy link
Member

@mgechev mgechev Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<html>

mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/projects/shell-browser/src/popups/production.html
@@ -0,0 +1,66 @@
<!DOCTYPE html>

Copy link
Member

@mgechev mgechev Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<html>

mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/projects/shell-browser/src/popups/supported.html
@@ -0,0 +1,73 @@
<!DOCTYPE html>

Copy link
Member

@mgechev mgechev Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<html>

mgechev
mgechev reviewed Apr 11, 2022
View changes
devtools/projects/shell-browser/src/popups/unsupported.html
@@ -0,0 +1,69 @@
<!DOCTYPE html>

Copy link
Member

@mgechev mgechev Apr 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<html>

mgechev
mgechev approved these changes Apr 11, 2022
View changes
Copy link
Member

@mgechev mgechev left a comment

LGTM once we resolve the typos! :)

@mgechev mgechev added target: minor and removed target: patch labels Apr 12, 2022
@mgechev
Copy link

@mgechev mgechev commented Apr 12, 2022

Changed the target to minor since this PR introduces a new feature.

@mgechev mgechev added action: merge and removed action: review labels Apr 12, 2022
@jessicajaniuk
Copy link

@jessicajaniuk jessicajaniuk commented Apr 12, 2022

This PR was merged into the repository by commit b5f39c5.

jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
docs(devtools): adding firefox development documentation (#44952)
60f2cfd 
Adding DevTools documentation for Firefox.

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
feat(devtools): updating firefox manifest json file (#44952)
2b73d95 
Updating `manifest.json` file for firefox.

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
docs(devtools): updating firefox development documentation (#44952)
47ceffc 
Updating Firefox DevTools documentation to be more descriptive and removing images.

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
feat(devtools): dynamic build support for devtools (#44952)
d54d1fd 
* Updating build to support both browsers firefox & chrome.
* Added new `config_setting` to support build.
* Added new genrule `copy_manifest` to `prodapp` pkg_web.

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
feat(devtools): renaming shell-chrome (#44952)
ceb19c0 
Renaming `shell-chrome` to `shell-browser` contains the build that supports both browsers.

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
docs(devtools): updating firefox documentation (#44952)
9f1bcc7 
Updating dist path to load Firefox DevTools

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
feat(devtools): adding firefox support (#44952)
bc0b6fe 
* Updating manifest.json to new build structure
* Adding doctype to pages to remove warnings

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
feat(devtools): added string flag for browser support (#44952)
e589bc6 
* Added `flag_browser` to toggle between different browser builds chrome and firefox
* Updated build command to support new flag configuration

PR Close #44952
jessicajaniuk pushed a commit that referenced this issue Apr 12, 2022
@sumitarora @jessicajaniuk
docs(devtools): updating firefox documentation (#44952)
b5f39c5 
updating typo

PR Close #44952
@pavankjadda pavankjadda mentioned this pull request Apr 12, 2022
Open
@mgechev mgechev deleted the feature/firefox branch Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JimMorrison723 JimMorrison723

@SchnWalter SchnWalter

@TimJ0212 TimJ0212

@mgechev mgechev

@devversion devversion

@AleksanderBodurri AleksanderBodurri

Assignees
No one assigned
Labels
action: merge comp: devtools target: minor
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@sumitarora @devversion @dylhunn @AndrewKushnir @mgechev @jessicajaniuk @JimMorrison723 @SchnWalter @AleksanderBodurri @TimJ0212