New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Move AST types to rome_rowan
#2372
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Parser conformance results on ubuntu-latestjs/262
jsx/babel
ts/babel
ts/microsoft
|
MichaReiser
reviewed
Apr 7, 2022
de245f1
to
1025226
Compare
rome_rowan
ematipico
approved these changes
Apr 8, 2022
ematipico
reviewed
Apr 8, 2022
leops
reviewed
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Summary
This PR parametrizes the
Asttraits with aLanguagetype and moves them to therome_rowancrate so that they can be shared betweenrome_js_syntaxandrome_css_syntax(and potential future crates).Other changes:
Syntax* aliases toJsSyntax*andCssSyntax. For example:type SyntaxNode = rome_rowan::SyntaxNode<JsLanguage>is now calledJsSyntaxNode. I believe this helps understanding the difference between the different nodes and aligns the naming with the kind types (that are calledJsSyntaxKindandCssSyntaxKindutilmethods to theSyntaxNodestruct.casttotry_castand move theSyntaxNodeExt::toto method toAstNodewith the namecast.Test Plan
cargo test