Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch from tabs to spaces #1941

Merged
merged 10 commits into from Jan 14, 2022
Merged

chore: switch from tabs to spaces #1941

merged 10 commits into from Jan 14, 2022

Conversation

Copy link
Collaborator

@yassere yassere commented Jan 14, 2022

Summary

Closes #1689

These are the main steps I took. If I forgot something, please let me know!

  • Removed hard_tab = true then ran cargo format
  • Ran cargo xtask syntax
  • Replaced some tabs that rustfmt didn't catch for some reason
  • Replaced tabs in comments (including inline parser tests) to avoid mixing tabs and spaces
  • Ran cargo xtask codegen and updated the .rast files

I also updated the .editorconfig but I've never really used it, so could someone check if I got that right?

Later, I'll add this commit to a .git-blame-ignore-revs but this needs to squash merge first so I can get its hash.

Test Plan

cargo test

@github-actions
Copy link

@github-actions github-actions bot commented Jan 14, 2022

Test262 comparison coverage results on ubuntu-latest

Test result main count This PR count Difference
Total 44951 44951 0
Passed 43447 43447 0
Failed 1503 1503 0
Panics 1 1 0
Coverage 96.65% 96.65% 0.00%

indent_style = space

[*.rs]
indent_size = 4
Copy link
Contributor

@MichaReiser MichaReiser Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nooo! Why 4... I want two spaces... Just kidding :P

@cloudflare-pages
Copy link

@cloudflare-pages cloudflare-pages bot commented Jan 14, 2022

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 084eeb1
Status:   Deploy successful!
Preview URL: https://033f310a.tools-8rn.pages.dev

View logs

@yassere yassere merged commit 409979f into main Jan 14, 2022
5 checks passed
@yassere yassere deleted the chore/tabs-to-spaces branch Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants