Python: Improve experimental modeling for pymongo#8696
Merged
Conversation
tausbn
approved these changes
May 9, 2022
Contributor
tausbn
left a comment
tausbn
left a comment
There was a problem hiding this comment.
This looks good to me! 👍
Only one minor comment (that does not need to be addressed before merging).
Comment on lines
52
to
55
| exists(SubscriptNode subscript | | ||
| subscript.getObject() = mongoInstance().getAUse().asCfgNode() and | ||
| subscript.getObject() = mongoClientInstance().getAUse().asCfgNode() and | ||
| result.asCfgNode() = subscript | ||
| ) |
Contributor
There was a problem hiding this comment.
This could also be written as
result.asCfgNode() = any(SubscriptNode subscript | subscript.getObject() = mongoClientInstance().getAUse().asCfgNode())though it's debatable whether this is an improvement.
Also, we really ought to add support for subscripting in the API graph (as a call to __getitem__). It really bothers me that we have to resort to type tracking here. 😢
Member
Author
There was a problem hiding this comment.
Also, we really ought to add support for subscripting in the API graph (as a call to getitem). It really bothers me that we have to resort to type tracking here. cry
Yes, that would be good 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides just adding new tests, I also fixed up the modeling, and did a small bit of refactoring. We want to promote this query at some point anyway, so could just as well do it now 🤷