Skip to content

C#: CaptureModel improvements#8675

Merged
michaelnebel merged 6 commits into
github:mainfrom
michaelnebel:csharp/capturemodelimprovement
Apr 21, 2022
Merged

C#: CaptureModel improvements#8675
michaelnebel merged 6 commits into
github:mainfrom
michaelnebel:csharp/capturemodelimprovement

Conversation

@michaelnebel
Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel commented Apr 6, 2022

In this PR, we remove summaries where

  • Simple types are used (ie. int, bool, long, etc).
  • Remove the previous way of excluding GetHashCode and Equals overrides (and IEqutable.Equals implementations) from summary generations.

@github-actions github-actions Bot added the C# label Apr 6, 2022
@michaelnebel michaelnebel force-pushed the csharp/capturemodelimprovement branch from 55d3c43 to 26ea5c2 Compare April 7, 2022 06:56
@michaelnebel michaelnebel force-pushed the csharp/capturemodelimprovement branch from 26ea5c2 to c79c9dd Compare April 19, 2022 10:51
@michaelnebel michaelnebel marked this pull request as ready for review April 19, 2022 10:51
@michaelnebel michaelnebel requested a review from a team as a code owner April 19, 2022 10:51
@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Apr 19, 2022
Comment thread csharp/ql/src/utils/model-generator/internal/CaptureModelsSpecific.qll Outdated
@michaelnebel michaelnebel merged commit 0ec5aa6 into github:main Apr 21, 2022
@michaelnebel michaelnebel deleted the csharp/capturemodelimprovement branch April 21, 2022 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants