Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: update to bazel v5 for new runfiles API used in dev-infra #45407

Closed
wants to merge 1 commit into from
Closed

build: update to bazel v5 for new runfiles API used in dev-infra #45407

wants to merge 1 commit into from
+1 −1

Conversation

devversion
Copy link
Member

@devversion devversion commented Mar 21, 2022

@devversion devversion requested a review from josephperrott Mar 21, 2022
@devversion devversion marked this pull request as ready for review Mar 21, 2022
@devversion devversion added comp: build & ci action: review target: patch labels Mar 21, 2022
@ngbot ngbot bot added this to the Backlog milestone Mar 21, 2022
@ngbot ngbot bot added this to the Backlog milestone Mar 21, 2022
@ngbot ngbot bot added this to the Backlog milestone Mar 21, 2022
@devversion
Copy link
Member Author

@devversion devversion commented Mar 21, 2022

Interesting that PullApprove fails. I will send a separate fix

josephperrott
josephperrott approved these changes Mar 21, 2022
View changes
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

@josephperrott josephperrott added action: merge and removed action: review labels Mar 21, 2022
@alxhub
Copy link
Contributor

@alxhub alxhub commented Mar 21, 2022

This PR was merged into the repository by commit e80df0d.

alxhub pushed a commit that referenced this issue Mar 21, 2022
@devversion @alxhub
build: update to bazel v5 for new runfiles API used in dev-infra (#45407
4321e4c 
)

https://blog.bazel.build/2022/01/19/bazel-5.0.html#starlark-build-language

PR Close #45407
PiyushAgrawal1243 pushed a commit to PiyushAgrawal1243/angular that referenced this issue Mar 30, 2022
@devversion @PiyushAgrawal1243
build: update to bazel v5 for new runfiles API used in dev-infra (ang…
70ea3b9 
…ular#45407)

https://blog.bazel.build/2022/01/19/bazel-5.0.html#starlark-build-language

PR Close angular#45407
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Apr 21, 2022

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@josephperrott josephperrott

Assignees
No one assigned
Labels
action: merge comp: build & ci PullApprove: disable target: patch
Projects
None yet
Milestone
Backlog
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devversion @alxhub @josephperrott