Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

in operator typeguard can widen types #46403

Open
wants to merge 56 commits into
base: main
Choose a base branch
from
Open

in operator typeguard can widen types #46403

wants to merge 56 commits into from

Conversation

@marekdedic
Copy link

@marekdedic marekdedic commented Oct 17, 2021 •
edited
Loading

Fixes #21732

This PR is a continuation of #39746 - thanks @ShuiRuTian for his work. I have made the branch up-to-date with main and fixed new test breakages. As I am not the original author of most of the changes, I would greatly appreciate a review either from @ShuiRuTian or the maintainers of TS.

Submission containing materials of a third party: @ShuiRuTian

Please verify that:

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run gulp runtests locally
  • There are new or updated unit tests validating the change
@microsoft-cla
Copy link

@microsoft-cla microsoft-cla bot commented Oct 17, 2021 •
edited
Loading

CLA assistant check
All CLA requirements met.

Loading

@marekdedic marekdedic changed the title in operator typeguard now can widen types in operator typeguard can widen types Oct 17, 2021
@marekdedic
Copy link
Author

@marekdedic marekdedic commented Oct 17, 2021

I have signed the CLA, however, I have no idea what to do with the code that is not my own - my layman's interpretation of the CLA is that if @ShuiRuTian signed the CLA as well, than it should all be OK. However, I can't check that he did.

Loading

@marekdedic marekdedic marked this pull request as draft Oct 17, 2021
@marekdedic
Copy link
Author

@marekdedic marekdedic commented Oct 19, 2021 •
edited
Loading

It looks like at least TS2361 has to be modified as well in order to allow for 'a' in b where b: unknown;.

Ok, I simplified it to 'a' in b where b: object, leaving the more general widening for later.

Loading

@ShuiRuTian
Copy link
Contributor

@ShuiRuTian ShuiRuTian commented Oct 22, 2021

Not worried, I signed the CLA too.

The changes until now looks good to me.

And please refer this commnet #39746 (comment)

Loading

marekdedic added 17 commits Oct 22, 2021
@marekdedic
Only adding properties directly to anonymous object types
5594882
@marekdedic
Accepted test baselines for test where property order changed
b9f6aaf
@marekdedic
Reorganized and simplified widenTypeWithSymbol()
4b4e63b
@marekdedic
Added more in operator tests
fbd0454
@marekdedic
Removed dead code
6b7b0b1
@marekdedic
Simplified controlFlowInOperator unit tests
225f5a1
@marekdedic
Reorganized and documented the logic of narrowOrWidenTypeByInKeyword
1f5c6c5
@marekdedic
Revert microsoft#38610 as it is no longer needed
c7641f1
@marekdedic
Accepted tests baselines
704ae12
@marekdedic
In operator not touching globalThis
83fda77
@marekdedic
Split filterUnionOrIntersectionType from filterType and deduplicated it
d739a5a
@marekdedic
Split out typeTests
b75b129
@marekdedic
Simplified logic around globalThis for in operator
624f586
@marekdedic
Marked type tests as internal
e53fb8a
@marekdedic
Added in operator unit test with call signature
8bc9ef4
@marekdedic
More thorough tests
5eb7dcd
@marekdedic
Added in operator unit test with index signature
6010fff
@marekdedic marekdedic marked this pull request as ready for review Oct 24, 2021
marekdedic
marekdedic reviewed Oct 24, 2021
View changes
src/compiler/checker.ts
function widenObjectType(type: ObjectType, newSymbol: Symbol): Type {
const members = createSymbolTable();
if (type.members !== undefined) {
mergeSymbolTable(members, type.members);
Copy link
Author

@marekdedic marekdedic Oct 24, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @weswigham
I was directed to your comment, however, I don't really know what to do with it. Ideally, I think I would like to clone the symbol table and just add the new symbol to it (that way there are no merges), but I can't figure out how to clone a symbol table :/

Loading

@sandersn sandersn added this to Not started in PR Backlog Oct 25, 2021
@sandersn sandersn removed this from Not started in PR Backlog Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Experiment For Backlog Bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Suggestion: treat in operator as type guard which asserts property existence
4 participants
@marekdedic @ShuiRuTian @sandersn @typescript-bot