Note git's core.longpaths in CONTRIBUTING #45069
Conversation
So people will be able to clone the repo on Windows. However, I'm not sure whether this addresses running tests.
typescript-bot
added
Author: Team
For Uncommitted Bug
|
I think the tests are fine (as long as you have long paths enabled in Windows - maybe we want to suggest that too?) because my original names were even longer and everything worked fine until I tried to add the new baselines to git. |
CONTRIBUTING.md
Outdated
| @@ -81,6 +81,10 @@ This repository includes a [development container](https://code.visualstudio.com | |||
|
|
|||
| The TypeScript repository is relatively large. To save some time, you might want to clone it without the repo's full history using `git clone --depth=1`. | |||
|
|
|||
| ### Filename too long on Windows | |||
|
|
|||
| You might need to run `git config --system core.longpaths true` before cloning Typescript on Windows. | |||
There was a problem hiding this comment.
On Windows if I try this I get
error: could not lock config file C:/Program Files/Git/etc/gitconfig: Permission denied
Should it be --global instead of --system?
There was a problem hiding this comment.
Both should work (they're just different config locations, both are essentially system-wide - one's just for your user, one is every user) - I guess it depends on how you have it installed as to weather you have rights for the system-wide one.
There was a problem hiding this comment.
I'll change it to global; I got the same error on Windows for system
CONTRIBUTING.md
Outdated
| @@ -81,6 +81,10 @@ This repository includes a [development container](https://code.visualstudio.com | |||
|
|
|||
| The TypeScript repository is relatively large. To save some time, you might want to clone it without the repo's full history using `git clone --depth=1`. | |||
|
|
|||
| ### Filename too long on Windows | |||
|
|
|||
| You might need to run `git config --system core.longpaths true` before cloning Typescript on Windows. | |||
There was a problem hiding this comment.
On Windows if I try this I get
error: could not lock config file C:/Program Files/Git/etc/gitconfig: Permission denied
Should it be --global instead of --system?
|
@DanielRosenwasser This is ready to review again. |
So people will be able to clone the repo on Windows. However, I'm not sure whether this addresses running tests.
Another fix for #45051, although #45054 is more important.