This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's oddly difficult to configure npm install. npm set config is lower priority than .npmrc and it only takes effect the next time you use npm install. As a result you can't use preinstall to disable the installation and you can't overwrite config set in .npmrc via npm config.
However, environment variables that are passed to the process supersede .npmrc, which is why I went with spawn a new process with the desired variable.
Contributors will not need to install Cypress unless they are working on
e2e tests. With these changes it will only install when npm run cypress
is invoked.
@raisedadead if we want to stop crash reports going to Cypress, we can, but it'll need to use cross-env for cypress and cypress:run. It doesn't work on precypress.
Won't that be the case only where we have the CI env configured with the keys? Everywhere else it will just fail? Which is fine. Or I am missing something.
Sounds like they get error reports when Cypress itself crashes, so I think it'll send them regardless of keys, but I'm not sure. The docs are here if you want to take a look.
A quick look tells me this is mostly for analytics for their product? IDK to be honest, lets give this a go as is, unless you have any more changes to the PR.
scope: tools/scriptsScripts for supporting dev work, generating config and build artifacts, etc.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.
ojeytonwilliams
added
the
scope: tools/scripts
raisedadead
changed the title
It's oddly difficult to configure
npm install.npm set configis lower priority than.npmrcand it only takes effect the next time you usenpm install. As a result you can't usepreinstallto disable the installation and you can't overwrite config set in.npmrcvianpm config.However, environment variables that are passed to the process supersede
.npmrc, which is why I went with spawn a new process with the desired variable.Closes #38636