Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tools): set git attributes for line endigs #35298

Merged

Conversation

Copy link
Contributor

@ValeraS ValeraS commented Feb 19, 2019

  • I have read freeCodeCamp's contribution guidelines.
  • My pull request has a descriptive title (not a vague title like Update index.md)
  • My pull request targets the master branch of freeCodeCamp.
  • None of my changes are plagiarized from another source without proper attribution.

@ValeraS ValeraS added the scope: tools/scripts label Feb 19, 2019
@ValeraS ValeraS requested a review from Feb 19, 2019
.eslintrc.json Outdated
@@ -3,7 +3,11 @@
"extends": ["@freecodecamp/eslint-config", "prettier", "prettier/react"],
"plugins": ["prettier"],
"rules": {
"prettier/prettier": "error"
"prettier/prettier": "error",
"max-len": [
Copy link
Contributor

@lipis lipis Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's sort the properties.

.gitattributes Outdated
*.ttf binary
*.eot binary
*.woff binary
*.pdf binary
Copy link
Contributor

@lipis lipis Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's sort them alphabetically.

Copy link
Member

@raisedadead raisedadead left a comment

Code LGTM. Can you address @lipis 's nit pick.

@ValeraS ValeraS force-pushed the fix/set-gitattributes-for-line-endigs branch 3 times, most recently from 989fcb3 to bbf4a78 Compare Feb 22, 2019
@ValeraS ValeraS force-pushed the fix/set-gitattributes-for-line-endigs branch from bbf4a78 to c7579a0 Compare Feb 22, 2019
@raisedadead raisedadead merged commit 0b2aac7 into freeCodeCamp:master Feb 22, 2019
1 check passed
@ValeraS ValeraS deleted the fix/set-gitattributes-for-line-endigs branch Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: tools/scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants