Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: tighten ESLint config #6931

Merged
merged 4 commits into from Mar 17, 2022
Merged

chore: tighten ESLint config #6931

merged 4 commits into from Mar 17, 2022

Conversation

Josh-Cena
Copy link
Collaborator

@Josh-Cena Josh-Cena commented Mar 17, 2022

Motivation

Enabled a few rules, disabled a few rules (that are eslint-disabled anyways).

Have you read the Contributing Guidelines on pull requests?

Yes

@Josh-Cena Josh-Cena requested review from slorber and lex111 as code owners Mar 17, 2022
@facebook-github-bot facebook-github-bot added the CLA Signed label Mar 17, 2022
@netlify
Copy link

@netlify netlify bot commented Mar 17, 2022

✔️ [V2]

🔨 Explore the source changes: 183e717

🔍 Inspect the deploy log: https://app.netlify.com/sites/docusaurus-2/deploys/6233033d6684bd000990266d

😎 Browse the preview: https://deploy-preview-6931--docusaurus-2.netlify.app

@github-actions
Copy link

@github-actions github-actions bot commented Mar 17, 2022

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 49
🟢 Accessibility 100
🟢 Best practices 92
🟢 SEO 100
🟢 PWA 90

Lighthouse ran on https://deploy-preview-6931--docusaurus-2.netlify.app/

@github-actions
Copy link

@github-actions github-actions bot commented Mar 17, 2022

Size Change: +6 B (0%)

Total Size: 792 kB

ℹ️ View Unchanged
Filename Size Change
website/.docusaurus/globalData.json 49.9 kB 0 B
website/build/assets/css/styles.********.css 105 kB 0 B
website/build/assets/js/main.********.js 599 kB +6 B (0%)
website/build/index.html 38.7 kB 0 B

compressed-size-action

@Josh-Cena Josh-Cena merged commit cc0bcea into main Mar 17, 2022
28 checks passed
@Josh-Cena Josh-Cena deleted the jc/eslint-config branch Mar 17, 2022
slorber added a commit that referenced this issue Mar 18, 2022
* chore: tighten ESLint config

* more refactor

* refactor push

* fix
@slorber slorber added the tag: internal label Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed tag: internal
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants