C#: Capture[Source|Sink]Models utility.#8482
Merged
michaelnebel merged 33 commits intogithub:mainfrom Mar 29, 2022
Merged
Conversation
michaelnebel
added
the
no-change-note-required
hvitved
requested changes
Mar 23, 2022
michaelnebel
force-pushed
the
csharp/capturesourcesink-models
branch
from
3f74e9a to
d9d15bc
Compare
hvitved
requested changes
Mar 28, 2022
michaelnebel
force-pushed
the
csharp/capturesourcesink-models
branch
from
1e91ca7 to
a405a4d
Compare
hvitved
previously approved these changes
Mar 29, 2022
Contributor
|
Thanks for your patience, @michaelnebel . |
Contributor
Author
Likewise! Thank you for being thorough! |
… TargetApi characteristic predicate.
…into a single file.
…s into a single file.
…s into a single file.
…els into a single file.
…include public fields and properties.
…ava.qll (same as in C#).
…Model specific implementations.
michaelnebel
force-pushed
the
csharp/capturesourcesink-models
branch
from
f35edca to
8e60073
Compare
Contributor
Author
|
@hvitved : You need to review again due to rebase (no changes was made since last approval and there were no rebase conflicts). |
hvitved
approved these changes
Mar 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we introduce two new utility queries including test-cases to capture
Note, that these queries can only identify new sources and sinks based on existing source and sinks.
It appears that there has only been (manually) identified a very limited set of sources and sinks for C#. This is an area, where we need further improvement.