Add on-demand compiler pool scaling #3550
Merged
+336
−84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use --compiler-pool-scaling-mode=on_demand to switch to the new mode, which will a spawn new compiler worker process every 3 seconds if the compiling requests keep queueing up, up to num of CPUs; after 60 seconds without compiling requests, the compiler pool will scale down to --compiler-pool-size with a default of 1 under on-demand mode.
1st1
reviewed
Feb 24, 2022
1st1
approved these changes
Mar 2, 2022
|
Should we merge this one? |
Sure - I was only concerned if we want to switch to use a DSN in #3555 for compilers, if so I'd update this one too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Use --compiler-pool-scaling-mode=on_demand to switch to the new mode,
which will a spawn new compiler worker process every 3 seconds if the
compiling requests keep queueing up, up to num of CPUs; after 60 seconds
without compiling requests, the compiler pool will scale down to
--compiler-pool-size with a default of 1 under on-demand mode.