COMP: Remove unused Annotations module components #6268
Conversation
jcfr
force-pushed
the
remove-unused-annotation-module-features
branch
from
c072b5a
to
c68f182
Compare
|
I also searched on GitHub for strings like Footnotes
|
This commit removes unused displayable managers and associated widgets & representations. The text and bidimensional disablaybale managers were disabled in 4809075 (ENH: Annotation: Cancel placement now uses events on the interaction Node and works properly again.)
This commit removes support for te Bidimensional node (class vtkMRMLAnnotationBidimensionalNode). The corresponding functionality has not been available to the user since 2011. The support for placing a new Bidimensional annotation has never been enabled in the vtkSlicerAnnotationModuleLogic class. See 0a97361 (BUG: removing non RSNA target annotations from the GUI.)
This commit removes support for Sticky node (class vtkMRMLAnnotationStickyNode). The corresponding functionality has never been available to the user since it was originally introduced in 2011. See 38cb7b6 (ENH: add to the list of annotation ids that can be active, with icons. Listen for the control point modified event)
This commit removes support for Spline node (class vtkMRMLAnnotationSplineNode). The corresponding functionality has never been available to the user since it was originally introduced in 2011. The support for placing a new Spline has never been enabled in the vtkSlicerAnnotationModuleLogic class. See 38cb7b6 (ENH: add to the list of annotation ids that can be active, with icons. Listen for the control point modified event)
This commit removes support for Angle node (class vtkMRMLAnnotationAngleNode). The corresponding functionality has never been available to the user since it was originally introduced in 2011. The support for placing a new Angle has never been enabled in the vtkSlicerAnnotationModuleLogic class. See 38cb7b6 (ENH: add to the list of annotation ids that can be active, with icons. Listen for the control point modified event)
jcfr
force-pushed
the
remove-unused-annotation-module-features
branch
from
c68f182
to
93c7415
Compare
|
Thank you, the changes looked good. These features were never exposed to end users so it was safe to remove them. |
Thanks for the follow up comment. |
This commit removes unused Annotations module MRML nodes, MRML displayable managers (with associated widgets & representations).
While looking at fixing
vtkMRMLAnnotationLinesNodeTest1andvtkMRMLAnnotationLinesStorageNodeTest1tests (which will likely be done by either removing or updating them), I realized a lot of code is not being irrelevant.