Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-42860: Remove type error from grammar #24156

Merged
merged 1 commit into from Jan 7, 2021
Merged

bpo-42860: Remove type error from grammar #24156

merged 1 commit into from Jan 7, 2021

Conversation

lysnikolaou
Copy link
Contributor

@lysnikolaou lysnikolaou commented Jan 7, 2021 •
edited by miss-islington

This is only there so that alternative implementations written in statically-typed languages can use this grammar without
having type errors in the way.

https://bugs.python.org/issue42860

Automerge-Triggered-By: GH:lysnikolaou

@lysnikolaou lysnikolaou requested a review from pablogsal Jan 7, 2021
@lysnikolaou lysnikolaou self-assigned this Jan 7, 2021
pablogsal
pablogsal approved these changes Jan 7, 2021
View changes
Copy link
Member

@pablogsal pablogsal left a comment

LGTM

statically-typed languages can use this grammar without having type errors in the way.

This is also our daily reminder that C is a statically typed language unless you start casting stuff to void* 😉

@lysnikolaou lysnikolaou added the 🤖 automerge PR will be merged once it's been approved and all CI passed label Jan 7, 2021
@miss-islington
Copy link
Contributor

miss-islington commented Jan 7, 2021

@lysnikolaou: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 07dcd86 into python:master Jan 7, 2021
3 checks passed
@lysnikolaou lysnikolaou deleted the parser-type-error branch Jan 7, 2021
@bedevere-bot
Copy link

bedevere-bot commented Jan 7, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot aarch64 RHEL7 3.x has failed when building commit 07dcd86.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/539/builds/542) and take a look at the build logs.
  4. Check if the failure is related to this commit (07dcd86) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/539/builds/542

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

412 tests OK.

10 slowest tests:

  • test_unparse: 4 min
  • test_tokenize: 3 min 47 sec
  • test_capi: 3 min 17 sec
  • test_concurrent_futures: 3 min 13 sec
  • test_multiprocessing_spawn: 2 min 52 sec
  • test_peg_generator: 2 min 48 sec
  • test_lib2to3: 2 min 15 sec
  • test_asyncio: 2 min 4 sec
  • test_unicodedata: 1 min 46 sec
  • test_multiprocessing_forkserver: 1 min 39 sec

1 test altered the execution environment:
test_asyncio

13 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_ossaudiodev
test_startfile test_tix test_tk test_ttk_guionly test_winconsoleio
test_winreg test_winsound test_zipfile64

Total duration: 8 min 48 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 321, in __del__
    self.close()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 316, in close
    self._ssl_protocol._start_shutdown()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 590, in _start_shutdown
    self._abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/sslproto.py", line 731, in _abort
    self._transport.abort()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 680, in abort
    self._force_close(None)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/selector_events.py", line 731, in _force_close
    self._loop.call_soon(self._call_connection_lost, exc)
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 745, in call_soon
    self._check_closed()
  File "/home/buildbot/buildarea/3.x.cstratak-RHEL7-aarch64/build/Lib/asyncio/base_events.py", line 510, in _check_closed
    raise RuntimeError('Event loop is closed')
RuntimeError: Event loop is closed

@lysnikolaou
Copy link
Contributor Author

lysnikolaou commented Jan 7, 2021

The buildbot failure seems unrelated to this PR.

@pablogsal
Copy link
Member

pablogsal commented Jan 7, 2021

The buildbot failure seems unrelated to this PR.

Yeah, is some recurring asyncio failure

adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@lysnikolaou @adorilson
bpo-42860: Remove type error from grammar (pythonGH-24156)
7bf4b93 
This is only there so that alternative implementations written in statically-typed languages can use this grammar without
having type errors in the way.

Automerge-Triggered-By: GH:lysnikolaou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablogsal pablogsal

Assignees

@lysnikolaou lysnikolaou

Labels
🤖 automerge PR will be merged once it's been approved and all CI passed skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@lysnikolaou @miss-islington @bedevere-bot @pablogsal @the-knights-who-say-ni