Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return fee in getrawtransaction #23264

Open
MarcoFalke opened this issue Oct 12, 2021 · 6 comments · May be fixed by #23319
Open

Return fee in getrawtransaction #23264

MarcoFalke opened this issue Oct 12, 2021 · 6 comments · May be fixed by #23319
Labels
Feature good first issue RPC/REST/ZMQ

Comments

@MarcoFalke
Copy link
Member

@MarcoFalke MarcoFalke commented Oct 12, 2021

Similar to how the fee is returned in getblock (#18771), it should be returned in getrawtransaction.

Useful skills:

Understanding of undo data, the RPC interface and the functional tests.

Want to work on this issue?

For guidance on contributing, please read CONTRIBUTING.md before opening your pull request.
@MarcoFalke MarcoFalke mentioned this issue Oct 12, 2021
Closed
@KenCox94
Copy link

@KenCox94 KenCox94 commented Oct 12, 2021

I'd love to take a look at this.

@meshcollider
Copy link
Member

@meshcollider meshcollider commented Oct 14, 2021

@KenCox94 if you need any pointers, please don't hesitate to ask here or on IRC #bitcoin-core-dev :)

@dougEfresh
Copy link
Contributor

@dougEfresh dougEfresh commented Oct 19, 2021

I'd love to take a look at this.

@KenCox94 I have a draft working solution. If you haven't already started, I would like to submit my PR.

@KenCox94
Copy link

@KenCox94 KenCox94 commented Oct 19, 2021

Sure!

@dougEfresh dougEfresh linked a pull request that will close this issue Oct 20, 2021
Open
@fanquake fanquake linked a pull request that will close this issue Oct 20, 2021
rpc: Return fee and prevout (utxos) to getrawtransaction #23319
Open
@viniciusdepadua
Copy link

@viniciusdepadua viniciusdepadua commented Nov 6, 2021

Is this issue still open? Could I help?

@fanquake
Copy link
Member

@fanquake fanquake commented Nov 6, 2021

This is being worked on in #23319. You could help by reviewing that PR.

@bitcoin bitcoin deleted a comment from Mdasgor Nov 7, 2021
@bitcoin bitcoin deleted a comment from PATOOCTOBER15 Nov 9, 2021
@bitcoin bitcoin deleted a comment Nov 23, 2021
@bitcoin bitcoin deleted a comment Nov 23, 2021
@bitcoin bitcoin deleted a comment Nov 23, 2021
@bitcoin bitcoin deleted a comment from TeresaHodges764 Mar 10, 2022
@bitcoin bitcoin deleted a comment from wangzemchd Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature good first issue RPC/REST/ZMQ
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

rpc: Return fee and prevout (utxos) to getrawtransaction
6 participants
@fanquake @dougEfresh @meshcollider @MarcoFalke @KenCox94 @viniciusdepadua